Issue 5839004: Change tegra2 binary builder to use board=tegra2_dev-board instead of tegra2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5839004: Change tegra2 binary builder to use board=tegra2_dev-board instead of tegra2. (Closed)

Created:
10 years ago by scottz

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils@master

Visibility:
Public.

Description

Change tegra2 binary builder to use board=tegra2_dev-board instead of tegra2. This aligns the binary builder with the full builder. BUG=NA TEST=NA Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4228f22

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	bin/cbuildbot_config.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

10 years ago (2010-12-16 21:40:53 UTC) #2

LGTM

On Thu, Dec 16, 2010 at 1:37 PM,  <scottz@chromium.org> wrote:
> Reviewers: sosa,
>
> Description:
> Change tegra2 binary builder to use board=tegra2_dev-board instead of
> tegra2.
> This aligns the binary builder with the full builder.
>
>
> BUG=NA
> TEST=NA
>
> Please review this at http://codereview.chromium.org/5839004/
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils@master
>
> Affected files:
>  M bin/cbuildbot_config.py
>
>
> Index: bin/cbuildbot_config.py
> diff --git a/bin/cbuildbot_config.py b/bin/cbuildbot_config.py
> index
>
ba3706e0f5af626ed19063cbc64209744d3c2581..2f7b6361ddc155e74e070f83006946c98da0355e
> 100644
> --- a/bin/cbuildbot_config.py
> +++ b/bin/cbuildbot_config.py
> @@ -100,7 +100,7 @@ config['x86_pineview_bin'] = {
>   'push_overlays': None,
>  }
>  config['arm_tegra2_bin'] = {
> -  'board' : 'tegra2',
> +  'board' : 'tegra2_dev-board',
>   'uprev' : True,
>   'master' : False,
>   'important' : False,
>
>
>

Expand Messages | Collapse Messages