Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: webkit/plugins/ppapi/ppb_graphics_3d_impl.h

Issue 5835007: Revert 69511 - Make Graphics3D::SwapBuffers take a completion callback... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/ppapi_plugin_instance.cc ('k') | webkit/plugins/ppapi/ppb_graphics_3d_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppb_graphics_3d_impl.h
===================================================================
--- webkit/plugins/ppapi/ppb_graphics_3d_impl.h (revision 69511)
+++ webkit/plugins/ppapi/ppb_graphics_3d_impl.h (working copy)
@@ -48,15 +48,15 @@
bool Init(PP_Instance instance_id, int32_t config,
const int32_t* attrib_list);
- // Associates this PPB_Graphics3D_Impl with the given plugin instance. You can
- // pass NULL to clear the existing device. Returns true on success. In this
- // case, the last rendered frame is displayed.
+ // Associates this PPB_Graphics3D_Impl with the given plugin instance. You can pass
+ // NULL to clear the existing device. Returns true on success. In this case,
+ // the last rendered frame is displayed.
// TODO(apatrick): Figure out the best semantics here.
bool BindToInstance(PluginInstance* new_instance);
bool MakeCurrent();
- bool SwapBuffers(PP_CompletionCallback callback);
+ bool SwapBuffers();
unsigned GetError();
@@ -64,9 +64,6 @@
void SetSwapBuffersCallback(Callback0::Type* callback);
- void ViewInitiatedPaint();
- void ViewFlushedPaint();
-
unsigned GetBackingTextureId();
gpu::gles2::GLES2Implementation* impl() {
@@ -80,10 +77,6 @@
// to, if any. If the context is currently unbound, this will be NULL.
PluginInstance* bound_instance_;
- // True when the page's SwapBuffers has been issued but not returned yet.
- bool swap_initiated_;
- PP_CompletionCallback swap_callback_;
-
// PluginDelegate's 3D Context. Responsible for providing the command buffer.
scoped_ptr<PluginDelegate::PlatformContext3D> platform_context_;
« no previous file with comments | « webkit/plugins/ppapi/ppapi_plugin_instance.cc ('k') | webkit/plugins/ppapi/ppb_graphics_3d_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698