AU: MultiHttpFetcher cleanup/rewrite

http_fetcher.h

Index: http_fetcher.h
diff --git a/http_fetcher.h b/http_fetcher.h
index a50c760f35aa519f27b0986193c148b8fc3a33bd..79561c09dc00304a568c93572195e0a0aabb9bd1 100644
--- a/http_fetcher.h
+++ b/http_fetcher.h
@@ -86,6 +86,11 @@ class HttpFetcher {
   virtual void set_idle_seconds(int seconds) {}
   virtual void set_retry_seconds(int seconds) {}
 
+  ProxyResolver* proxy_resolver() const { return proxy_resolver_; }
+  
+  virtual void SetConnectionAsExpensive(bool is_expensive) {}

[petkov, 2010/12/16 18:30:57]

Maybe add a comment that these methods are used for testing.

[adlr, 2010/12/17 01:03:51]

Done.

+  virtual void SetBuildType(bool is_official) {}
+
  protected:
   // The URL we're actively fetching from
   std::string url_;
@@ -122,6 +127,9 @@ class HttpFetcherDelegate {
   // Called if the fetcher seeks to a particular offset.
   virtual void SeekToOffset(off_t offset) {}
 
+  // When a transfer has completed, exactly one of these two methods will be

[petkov, 2010/12/16 18:30:57]

You may want to combine the docstrings for the two methods into a single
docstring and then just declare the methods.

[adlr, 2010/12/17 01:03:51]

Done.

+  // called:
+
   // Called when the transfer has completed successfully or been aborted through
   // means other than TerminateTransfer. It's OK to destroy the |fetcher| object
   // in this callback.