AU: MultiHttpFetcher cleanup/rewrite

http_fetcher.h

 // Copyright (c) 2009 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_PLATFORM_UPDATE_ENGINE_HTTP_FETCHER_H__
 #define CHROMEOS_PLATFORM_UPDATE_ENGINE_HTTP_FETCHER_H__
 
 #include <deque>
 #include <string>
 #include <vector>
@@ skipping 68 matching lines @@
   // Used to unpause an HttpFetcher and let the bytes stream in again.
   // If a delegate is set, ReceivedBytes() may be called on it before
   // Unpause() returns
   virtual void Unpause() = 0;
 
   // These two function are overloaded in LibcurlHttp fetcher to speed
   // testing.
   virtual void set_idle_seconds(int seconds) {}
   virtual void set_retry_seconds(int seconds) {}
 
+  ProxyResolver* proxy_resolver() const { return proxy_resolver_; }
+  
+  virtual void SetConnectionAsExpensive(bool is_expensive) {}

[petkov, 2010/12/16 18:30:57]

Maybe add a comment that these methods are used for testing.

[adlr, 2010/12/17 01:03:51]

Done.

+  virtual void SetBuildType(bool is_official) {}
+
  protected:
   // The URL we're actively fetching from
   std::string url_;
 
   // POST data for the transfer, and whether or not it was ever set
   bool post_data_set_;
   std::vector<char> post_data_;
 
   // The server's HTTP response code from the last transfer. This
   // field should be set to 0 when a new transfer is initiated, and
@@ skipping 16 matching lines @@
 class HttpFetcherDelegate {
  public:
   // Called every time bytes are received.
   virtual void ReceivedBytes(HttpFetcher* fetcher,
                              const char* bytes,
                              int length) = 0;
 
   // Called if the fetcher seeks to a particular offset.
   virtual void SeekToOffset(off_t offset) {}
 
+  // When a transfer has completed, exactly one of these two methods will be

[petkov, 2010/12/16 18:30:57]

You may want to combine the docstrings for the two methods into a single
docstring and then just declare the methods.

[adlr, 2010/12/17 01:03:51]

Done.

+  // called:
+
   // Called when the transfer has completed successfully or been aborted through
   // means other than TerminateTransfer. It's OK to destroy the |fetcher| object
   // in this callback.
   virtual void TransferComplete(HttpFetcher* fetcher, bool successful) = 0;

[petkov, 2010/12/16 18:30:57]

Side note: Chrome has a convention to use "OnEvent" style names for this sort of
callback methods (e.g., "OnTransferComplete"). It might make sense to adopt a
similar convention (or at least some convention) for the rest of the Chrome OS
packages (or at least for the update engine).

[adlr, 2010/12/17 01:03:51]

That's a good idea. I'll make a note to update our callbacks like this.

 
   // Called when the transfer has been aborted through TerminateTransfer. It's
   // OK to destroy the |fetcher| object in this callback.
   virtual void TransferTerminated(HttpFetcher* fetcher) {}
 };
 
 }  // namespace chromeos_update_engine
 
 #endif  // CHROMEOS_PLATFORM_UPDATE_ENGINE_HTTP_FETCHER_H__