Issue 583008: Eliminate *IC::Generate() function on all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 583008: Eliminate *IC::Generate() function on all platforms. (Closed)

Created:
10 years, 10 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Eliminate *IC::Generate() function on all platforms. Committed: http://code.google.com/p/v8/source/detail?r=3817

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -127 lines)			Patch
M	src/arm/ic-arm.cc	View		9 chunks	+34 lines, -23 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1	10 chunks	+40 lines, -29 lines	0 comments	Download
M	src/ic.h	View	1	6 chunks	+11 lines, -11 lines	0 comments	Download
M	src/ic.cc	View	1	3 chunks	+0 lines, -30 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1 2	9 chunks	+44 lines, -34 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. On ia32/x64, some places we move from stack memory to registers and then push, ...

10 years, 10 months ago (2010-02-08 15:22:49 UTC) #2

William Hesse

10 years, 10 months ago (2010-02-08 16:05:34 UTC) #3

I changed all of the stack-rearranging to push stack operands, rather than
loading to registers, making them uniform.

http://codereview.chromium.org/583008/diff/1/3
File src/ic.cc (right):

http://codereview.chromium.org/583008/diff/1/3#newcode1323
src/ic.cc:1323: void LoadIC::GenerateInitialize(MacroAssembler* masm) {
On 2010/02/08 15:22:49, Kevin Millikin wrote:
> I think it's OK to put all these in the ic.h file.

Done.

Expand Messages | Collapse Messages