Issue 5828004: IA32: Optimize instanceof...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5828004: IA32: Optimize instanceof... (Closed)

Created:
10 years ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

IA32: Optimize instanceof The instanceoff stub now supports arguments in registers and checks for null, smi and string values without going to runtime. Needs porting to X64 and ARM. Committed: http://code.google.com/p/v8/source/detail?r=6042

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -59 lines)			Patch
M	src/arm/codegen-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/full-codegen-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/code-stubs.h	View	1	1 chunk	+13 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	1 chunk	+90 lines, -41 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		2 chunks	+3 lines, -6 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/v8-counters.h	View		1 chunk	+9 lines, -1 line	2 comments	Download
M	src/x64/codegen-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/full-codegen-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/5828004/diff/13001/src/v8-counters.h File src/v8-counters.h (right): http://codereview.chromium.org/5828004/diff/13001/src/v8-counters.h#newcode251 src/v8-counters.h:251: SC(instance_of, V8.InstanceOf) \ Should we get rid of ...

10 years ago (2010-12-16 08:44:43 UTC) #2

Søren Thygesen Gjesse

10 years ago (2010-12-16 08:58:28 UTC) #3

http://codereview.chromium.org/5828004/diff/13001/src/v8-counters.h
File src/v8-counters.h (right):

http://codereview.chromium.org/5828004/diff/13001/src/v8-counters.h#newcode251
src/v8-counters.h:251: SC(instance_of, V8.InstanceOf)                           
          \
On 2010/12/16 08:44:43, Mads Ager wrote:
> Should we get rid of some of these counters before submit?

I would like to keep them for a couple of days while looking for more
optimizations. I will remove them later.

Expand Messages | Collapse Messages