run_remote_tests.sh: pass multiple arguments to autoserv

run_remote_tests.sh: pass multiple arguments to autoserv

Change-Id: I7f54a0e078d0c7eb70e0a614bbb991cd372dec60

BUG=chromium-os:9841
TEST=
## Test with these 2 scripts
./bin/cros_run_wifi_tests.sh --cell 3 MatFunc --args "test_pat=000*"
## --and--
./run_remote_tests.sh --remote=${DUT} --args="test_pat=000* config_file=wifi_testbed_chromelab server_addr=${SERVER} router_addr=${ROUTER}" MatFunc

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b38b3c8

[Daniel Kurtz, 2010-12-14 18:06:42]

This patch works with the common WiFi test usage.
I don't know what other use cases there are for run_remote_tests.sh with args.

[Sam Leffler, 2010-12-14 19:13:01]

LGTM on this w/ caveat.  This works only when running inside the chroot.  When
outside things are still busted.

[ericli, 2010-12-14 19:19:41]

LGTM as long as you guys tested it.

On 2010/12/14 19:13:01, Sam Leffler wrote:
> LGTM on this w/ caveat.  This works only when running inside the chroot.  When
> outside things are still busted.

[kmixter1, 2010-12-14 19:32:35]

How does this work?  Can't FLAGS_args have spaces in it and if so
wouldn't those things after the space be passed as raw arguments to
autoserv instead of as --args?


On Tue, Dec 14, 2010 at 11:19 AM,  <ericli@chromium.org> wrote:
> LGTM as long as you guys tested it.
>
> On 2010/12/14 19:13:01, Sam Leffler wrote:
>>
>> LGTM on this w/ caveat.  This works only when running inside the chroot.
>>  When
>> outside things are still busted.
>
>
>
> http://codereview.chromium.org/5821001/
>

[Sam Leffler, 2010-12-14 19:41:01]

I agree.  The change makes no sense to me but appears to work for all the test
cases I used.  But like I said only in the chroot which is not how I ever use
this stuff.  IMO we should revert back to what worked and start over.

[Daniel Kurtz, 2010-12-14 20:03:32]

args is documented as: "Command line arguments for test. Quoted and space
separated if multiple."

So, I interpret this as the caller being responsible for passing in --args="arg1
arg2 arg3"

Thus, FLAGS_args="arg1 arg2 arg3", so you shouldn't need to add more quotes to
FLAGS_args before passing to autoserv.

Am I missing something?

On 2010/12/14 19:32:35, kmixter1 wrote:
> How does this work?  Can't FLAGS_args have spaces in it and if so
> wouldn't those things after the space be passed as raw arguments to
> autoserv instead of as --args?
> 
> 
> On Tue, Dec 14, 2010 at 11:19 AM,  <mailto:ericli@chromium.org> wrote:
> > LGTM as long as you guys tested it.
> >
> > On 2010/12/14 19:13:01, Sam Leffler wrote:
> >>
> >> LGTM on this w/ caveat. &nbsp;This works only when running inside the
chroot.
> >> &nbsp;When
> >> outside things are still busted.
> >
> >
> >
> > http://codereview.chromium.org/5821001/
> >

[Daniel Kurtz, 2010-12-15 04:11:44]

Update to work both inside & outside chroot.

However, sudo 1.7.2p1 is broken (See chromium-os:7072).  It cannot properly
handle multi-word arguments when using '-i', such as in enter_chroot.sh.

This will be fixed when we uprev to sudo 1.7.4p4.

Until then, tests can only be run within the chroot.

[ericli, 2010-12-15 18:24:58]

LGTM.
On 2010/12/15 04:11:44, djkurtz wrote:
> Update to work both inside & outside chroot.
> 
> However, sudo 1.7.2p1 is broken (See chromium-os:7072).  It cannot properly
> handle multi-word arguments when using '-i', such as in enter_chroot.sh.
> 
> This will be fixed when we uprev to sudo 1.7.4p4.
> 
> Until then, tests can only be run within the chroot.