Minor changes to simplify IsValidLocaleSyntax logic.

Minor changes to simplify IsValidLocaleSyntax logic.
BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69130

[Nebojša Ćirić, 2010-12-13 19:43:48]

http://codereview.chromium.org/5816001/diff/4001/app/l10n_util.cc
File app/l10n_util.cc (right):

http://codereview.chromium.org/5816001/diff/4001/app/l10n_util.cc#newcode552
app/l10n_util.cc:552: if (ch == '_') {
You don't use ch anywhere else. Remove it and use prefix[i] directly.

You can also remove nested if (you can skip this):
for () {
  if (prefix[i] != '_') {
    token_len++;
    continue;
  }
  if (token_index == 0 && (token_len < 1)...) {
    return false;
  }

  token_index++;
  token_len = 0;
}

[Nebojša Ćirić, 2010-12-13 20:06:42]

LGTM (looking at the patch set 3) as long as try bots pass.

Thanks for doing this.

On 2010/12/13 19:43:48, Nebojša Ćirić wrote:
> http://codereview.chromium.org/5816001/diff/4001/app/l10n_util.cc
> File app/l10n_util.cc (right):
> 
> http://codereview.chromium.org/5816001/diff/4001/app/l10n_util.cc#newcode552
> app/l10n_util.cc:552: if (ch == '_') {
> You don't use ch anywhere else. Remove it and use prefix[i] directly.
> 
> You can also remove nested if (you can skip this):
> for () {
>   if (prefix[i] != '_') {
>     token_len++;
>     continue;
>   }
>   if (token_index == 0 && (token_len < 1)...) {
>     return false;
>   }
> 
>   token_index++;
>   token_len = 0;
> }