Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: base/file_version_info.h

Issue 5815001: Fixed file_version_info so that it finds Mac values correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Simplified the change due to problems getting the older patch to work with chrome frame. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/file_version_info_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_version_info.h
diff --git a/base/file_version_info.h b/base/file_version_info.h
index 19407d29bd9ccd3b0ae75843db8243d24eacd13a..41a97fa9d1f0367fca3d2c55b367638fb40d9cf6 100644
--- a/base/file_version_info.h
+++ b/base/file_version_info.h
@@ -24,10 +24,13 @@ class FileVersionInfo {
// goes wrong (typically the file does not exit or cannot be opened). The
// returned object should be deleted when you are done with it.
static FileVersionInfo* CreateFileVersionInfo(const FilePath& file_path);
+#endif // OS_WIN || OS_MACOSX
+
+#if defined(OS_WIN)
// This version, taking a wstring, is deprecated and only kept around
// until we can fix all callers.
static FileVersionInfo* CreateFileVersionInfo(const std::wstring& file_path);
-#endif
+#endif // OS_WIN
// Creates a FileVersionInfo for the current module. Returns NULL in case
// of error. The returned object should be deleted when you are done with it.
« no previous file with comments | « no previous file | base/file_version_info_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698