chrome/test/automation/automation_proxy.cc - Issue 5815001: Fixed file_version_info so that it finds Mac values correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/automation/automation_proxy.cc

Issue 5815001: Fixed file_version_info so that it finds Mac values correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changed logging to vlog Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/automation/automation_proxy.cc

diff --git a/chrome/test/automation/automation_proxy.cc b/chrome/test/automation/automation_proxy.cc

index 4da271ba80e984736f44bff14f84d78df5b74992..62b003e40a8a3c5c05b5a6f9d9d8de7644712090 100644

--- a/chrome/test/automation/automation_proxy.cc

+++ b/chrome/test/automation/automation_proxy.cc

@@ -174,7 +174,6 @@ AutomationLaunchResult AutomationProxy::WaitForAppLaunch() {

// Obtain our own version number and compare it to what the automation

// provider sent.

chrome::VersionInfo version_info;

- DCHECK(version_info.is_valid());

// Note that we use a simple string comparison since we expect the version

// to be a punctuated numeric string. Consider using base/Version if we