Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8839)

Unified Diff: chrome/common/extensions/extension.cc

Issue 5815001: Fixed file_version_info so that it finds Mac values correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changed logging to vlog Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 687d3f4e479f9b07761c8f6f13dd6f87ca739ad8..f09eef102b8a1dfb630759a374e69fa86ca062a0 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -1344,11 +1344,6 @@ bool Extension::InitFromValue(const DictionaryValue& source, bool require_key,
}
chrome::VersionInfo current_version_info;
- if (!current_version_info.is_valid()) {
- NOTREACHED();
- return false;
- }
-
scoped_ptr<Version> current_version(
Version::GetVersionFromString(current_version_info.Version()));
if (!current_version.get()) {

Powered by Google App Engine
This is Rietveld 408576698