chrome/browser/dom_ui/options/about_page_handler.cc - Issue 5815001: Fixed file_version_info so that it finds Mac values correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/dom_ui/options/about_page_handler.cc

Issue 5815001: Fixed file_version_info so that it finds Mac values correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changed logging to vlog Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/dom_ui/options/about_page_handler.cc

diff --git a/chrome/browser/dom_ui/options/about_page_handler.cc b/chrome/browser/dom_ui/options/about_page_handler.cc

index c34774791badcf726d5e1fcd03dbf7f12b2de6ce..d4ae01e31ed8ba9c5257025f468500c9cc1b6350 100644

--- a/chrome/browser/dom_ui/options/about_page_handler.cc

+++ b/chrome/browser/dom_ui/options/about_page_handler.cc

@@ -144,8 +144,6 @@ void AboutPageHandler::GetLocalizedValues(DictionaryValue* localized_strings) {

// browser version

chrome::VersionInfo version_info;

- DCHECK(version_info.is_valid());

std::string browser_version = version_info.Version();

std::string version_modifier = platform_util::GetVersionStringModifier();

if (!version_modifier.empty())