chrome/browser/diagnostics/recon_diagnostics.cc - Issue 5815001: Fixed file_version_info so that it finds Mac values correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/diagnostics/recon_diagnostics.cc

Issue 5815001: Fixed file_version_info so that it finds Mac values correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changed logging to vlog Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/diagnostics/recon_diagnostics.cc

diff --git a/chrome/browser/diagnostics/recon_diagnostics.cc b/chrome/browser/diagnostics/recon_diagnostics.cc

index f657fefc7147bb55b0c868a83c74e83b6e25360a..0a572f3e6d481003e2c3ac0b5cc9bdab27562d2c 100644

--- a/chrome/browser/diagnostics/recon_diagnostics.cc

+++ b/chrome/browser/diagnostics/recon_diagnostics.cc

@@ -117,10 +117,6 @@ class VersionTest : public DiagnosticTest {

virtual bool ExecuteImpl(DiagnosticsModel::Observer* observer) {

chrome::VersionInfo version_info;

- if (!version_info.is_valid()) {

- RecordFailure(ASCIIToUTF16("No Version"));

- return true;

- }

std::string current_version = version_info.Version();

if (current_version.empty()) {

RecordFailure(ASCIIToUTF16("Empty Version"));