chrome/common/extensions/extension.cc - Issue 5815001: Fixed file_version_info so that it finds Mac values correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 5815001: Fixed file_version_info so that it finds Mac values correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: added a file Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index 687d3f4e479f9b07761c8f6f13dd6f87ca739ad8..f09eef102b8a1dfb630759a374e69fa86ca062a0 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -1344,11 +1344,6 @@ bool Extension::InitFromValue(const DictionaryValue& source, bool require_key,

}

chrome::VersionInfo current_version_info;

- if (!current_version_info.is_valid()) {

- NOTREACHED();

- return false;

- }

scoped_ptr<Version> current_version(

Version::GetVersionFromString(current_version_info.Version()));

if (!current_version.get()) {