chrome/browser/upgrade_detector.cc - Issue 5815001: Fixed file_version_info so that it finds Mac values correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/upgrade_detector.cc

Issue 5815001: Fixed file_version_info so that it finds Mac values correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: added a file Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/upgrade_detector.cc

diff --git a/chrome/browser/upgrade_detector.cc b/chrome/browser/upgrade_detector.cc

index a8928f169de4b1cd9519cc4fbab72d704a26c7d8..73f5f2548a774e8c8b038ebcc431f279550e2776 100644

--- a/chrome/browser/upgrade_detector.cc

+++ b/chrome/browser/upgrade_detector.cc

@@ -114,10 +114,6 @@ class DetectUpgradeTask : public Task {

// Get the version of the currently *running* instance of Chrome.

chrome::VersionInfo version_info;

- if (!version_info.is_valid()) {

- NOTREACHED() << "Failed to get current file version";

- return;

- }

scoped_ptr<Version> running_version(

Version::GetVersionFromString(ASCIIToUTF16(version_info.Version())));

if (running_version.get() == NULL) {