Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2339)

Unified Diff: chrome/browser/extensions/extension_updater.cc

Issue 5815001: Fixed file_version_info so that it finds Mac values correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added a file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_updater.cc
diff --git a/chrome/browser/extensions/extension_updater.cc b/chrome/browser/extensions/extension_updater.cc
index d1430521ef6e262a2fe34ca70d45ae288d9111fd..1ebf65b8241629172636d014e2f95dc2d3646f5e 100644
--- a/chrome/browser/extensions/extension_updater.cc
+++ b/chrome/browser/extensions/extension_updater.cc
@@ -827,10 +827,8 @@ std::vector<int> ExtensionUpdater::DetermineUpdates(
// First determine the browser version if we haven't already.
if (!browser_version.get()) {
chrome::VersionInfo version_info;
- if (version_info.is_valid()) {
- browser_version.reset(Version::GetVersionFromString(
- version_info.Version()));
- }
+ browser_version.reset(Version::GetVersionFromString(
+ version_info.Version()));
}
scoped_ptr<Version> browser_min_version(
Version::GetVersionFromString(update->browser_min_version));

Powered by Google App Engine
This is Rietveld 408576698