Minimize login prompts

net/tools/testserver/testserver.py

Index: net/tools/testserver/testserver.py
diff --git a/net/tools/testserver/testserver.py b/net/tools/testserver/testserver.py
index 0cd663d8434551dc1f4b442edf67c8bbd222059e..23472b0ddc75e35f072ee40f862e7773544a26a4 100755
--- a/net/tools/testserver/testserver.py
+++ b/net/tools/testserver/testserver.py
@@ -914,6 +914,11 @@ class TestPageHandler(BasePageHandler):
 
     set_cookie_if_challenged = self.path.find('?set-cookie-if-challenged') > 0

[cbentzel, 2010/12/17 19:22:56]

Could you shift this to urlparse and cgi.parse_qs rather than doing regexps
directly? That would make this clearer, and probably work on some weird corner
cases. 

 
+    pw_list = re.findall(r'[&?]password=([^&]+)', self.path) + ['secret']
+    realm_list = re.findall(r'[&?]realm=([^&]+)', self.path) + ['testrealm']
+    expected_password = pw_list[0]
+    realm = realm_list[0]
+
     auth = self.headers.getheader('authorization')
     try:
       if not auth:
@@ -921,12 +926,12 @@ class TestPageHandler(BasePageHandler):
       b64str = re.findall(r'Basic (\S+)', auth)[0]
       userpass = base64.b64decode(b64str)
       username, password = re.findall(r'([^:]+):(\S+)', userpass)[0]
-      if password != 'secret':
+      if password != expected_password:
         raise Exception('wrong password')
     except Exception, e:
       # Authentication failed.
       self.send_response(401)
-      self.send_header('WWW-Authenticate', 'Basic realm="testrealm"')
+      self.send_header('WWW-Authenticate', 'Basic realm="%s"' % realm)
       self.send_header('Content-type', 'text/html')
       if set_cookie_if_challenged:
         self.send_header('Set-Cookie', 'got_challenged=true')