Minimize login prompts

chrome/browser/ui/login/login_prompt.h

Index: chrome/browser/ui/login/login_prompt.h
diff --git a/chrome/browser/ui/login/login_prompt.h b/chrome/browser/ui/login/login_prompt.h
index 8e3d15e0dc5f714997546b6bdef97baa2a1e9a0e..bcce9f2a3a15511f4bd6267a158145a5e1687613 100644
--- a/chrome/browser/ui/login/login_prompt.h
+++ b/chrome/browser/ui/login/login_prompt.h
@@ -70,6 +70,12 @@ class LoginHandler : public base::RefCountedThreadSafe<LoginHandler>,
                        const NotificationSource& source,
                        const NotificationDetails& details);
 
+  // Who/where/what asked for the authentication.
+  net::AuthChallengeInfo* auth_info() const { return auth_info_.get(); }

[cbentzel, 2011/01/05 13:13:52]

This should return a const net::AuthChallengeInfo* since it's labeled const -
otherwise the underlying data could be mutated. 

[asanka (google), 2011/01/05 14:29:11]

Done.

+
+  // Returns whether authentication had been handled (SetAuth or CancelAuth).
+  bool WasAuthHandled();

[cbentzel, 2011/01/05 13:13:52]

This should probably be const.

[asanka (google), 2011/01/05 14:29:11]

Done.

+
  protected:
   void SetModel(LoginModel* model);
 
@@ -81,9 +87,6 @@ class LoginHandler : public base::RefCountedThreadSafe<LoginHandler>,
   // Performs necessary cleanup before deletion.
   void ReleaseSoon();
 
-  // Who/where/what asked for the authentication.
-  net::AuthChallengeInfo* auth_info() const { return auth_info_.get(); }
-
  private:
   // Starts observing notifications from other LoginHandlers.
   void AddObservers();
@@ -98,9 +101,9 @@ class LoginHandler : public base::RefCountedThreadSafe<LoginHandler>,
   // Notify observers that authentication is cancelled.
   void NotifyAuthCancelled();
 
-  // Returns whether authentication had been handled (SetAuth or CancelAuth).
-  // If |set_handled| is true, it will mark authentication as handled.
-  bool WasAuthHandled(bool set_handled);
+  // Marks authentication as handled and returns the previous handled
+  // state.
+  bool TestAndSetAuthHandled();
 
   // Calls SetAuth from the IO loop.
   void SetAuthDeferred(const std::wstring& username,