Fixing a regression introduced with r69101, which now prevents Chrome Frame...

Fixing a regression introduced with r69101, which now prevents Chrome Frame
from loading chrome extension URL in privileged mode using the NPAPI plugin.
The behaviour that was implemented only for the ActiveX control has been
moved into the base class NavigationConstraintsImpl, which both the ActieX
and NPAPI plugin derive from.

TEST=Added new unit tests for this case
BUG=0
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69257

[amit, 2010-12-14 19:37:58]

Thanks for catching this! drive by...

http://codereview.chromium.org/5814004/diff/1/chrome_frame/chrome_frame_npapi.cc
File chrome_frame/chrome_frame_npapi.cc (right):

http://codereview.chromium.org/5814004/diff/1/chrome_frame/chrome_frame_npapi...
chrome_frame/chrome_frame_npapi.cc:422: bool
ChromeFrameNPAPI::IsSchemeAllowed(const GURL& url) {
This looks identical to the ActiveX version. So maybe move this down to the base
class and have a dcheck(!is_privileged_) in the ActiveDoc::IsSchemeAllowed(...)
for now?

[Roger Tawa OOO till Jul 10th, 2010-12-14 22:12:54]

Hi Amit,

Moved the code to a common place.  I don't understand what you mean by adding a
DCHECK though.

Amit, Ananta: please take another look.  Thanks.

[amit, 2010-12-14 22:18:20]

lgtm as long as ananta is fine with it :)

[ananta, 2010-12-14 22:18:29]

LGTM