Issue 5812004: Allow hypen in domain name of email address for ChromeOS users UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5812004: Allow hypen in domain name of email address for ChromeOS users UI. (Closed)

Created:
10 years ago by xiyuan

Modified:
9 years, 7 months ago

Reviewers:
zel

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Allow hypen in domain name of email address for ChromeOS users UI. Change '\w+' to [A-Za-z0-9]{2,63} in email address regexp. This allows hypen to be used in domain name part of an email and sets a 2-63 chars length limit. Use the same email alias pattern for format3 as in format1 and format2. BUG=chromium-os:10250 TEST=Verify fix for chromim-os:10250. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69153

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/resources/options/chromeos_accounts_user_name_edit.js	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages