Issue 5806001: Support %_IsObject in Crankshaft.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5806001: Support %_IsObject in Crankshaft. (Closed)

Created:
10 years ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Support %_IsObject in Crankshaft. Committed: http://code.google.com/p/v8/source/detail?r=6027

Patch Set 1 #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+262 lines, -5 lines)			Patch
M	src/arm/lithium-arm.h	View	3 chunks	+46 lines, -0 lines	1 comment	Download
M	src/arm/lithium-arm.cc	View	3 chunks	+24 lines, -0 lines	1 comment	Download
M	src/arm/lithium-codegen-arm.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+9 lines, -5 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	3 chunks	+10 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+65 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	3 chunks	+46 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	3 chunks	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

10 years ago (2010-12-15 11:45:38 UTC) #2

LGTM.  I know the other Lithium instructions are only deterministic up to
evaluation order, but I don't think we should introduce more sites like that.

http://codereview.chromium.org/5806001/diff/1/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):

http://codereview.chromium.org/5806001/diff/1/src/arm/lithium-arm.cc#newcode1252
src/arm/lithium-arm.cc:1252: return new
LIsObjectAndBranch(UseRegisterAtStart(compare->value()),
Since evaluation order is unspecified and we want the register allocator to be
deterministic, I think we should name all these LOperands.

http://codereview.chromium.org/5806001/diff/1/src/arm/lithium-arm.h
File src/arm/lithium-arm.h (right):

http://codereview.chromium.org/5806001/diff/1/src/arm/lithium-arm.h#newcode756
src/arm/lithium-arm.h:756: LOperand* temp() { return temp_; }
We've made these accessors const in this file, so you should probably keep that
style.

Expand Messages | Collapse Messages