Issue 5804005: Enable default apps by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5804005: Enable default apps by default. (Closed)

Created:
10 years ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Bons

CC:
chromium-reviews, arv (Not doing code reviews), Erik does not do reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Enable default apps by default. Also, always show the apps section. We were only hiding it when there was zero elements when we were in our transitionary phase. To make this look less weird when there are actually zero elements, add the webstore element to the miniview and closed menus. BUG=64737 TEST=In a fresh profile, go to chrome://extensions/ -> developer mode, and click 'update now'. Go to NTP. Should see default apps. Remove all default apps. Apps section should remain. Collapse apps section by clicking heading. Should see webstore item in minimized view. Hide apps section by clicking 'x'. Should see webstore item in closed section menu on bottom of page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69180

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -39 lines)			Patch
M	chrome/browser/dom_ui/app_launcher_handler.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/ntp/apps.js	View	3 chunks	+35 lines, -18 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

woot for deleting stuff!

Expand Messages | Collapse Messages