Issue 5804004: Add Debug Message Dialog Support for Mac OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5804004: Add Debug Message Dialog Support for Mac OS (Closed)

Created:
10 years ago by dmac

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan, Nico, viettrungluu

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add Debug Message Dialog Support for Mac OS BUG=37026 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69138

Patch Set 2 : alphabet issues #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	base/logging.cc	View	1	2 chunks	+12 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

LGTM with tiny nit. http://codereview.chromium.org/5804004/diff/2001/base/logging.cc File base/logging.cc (right): http://codereview.chromium.org/5804004/diff/2001/base/logging.cc#newcode57 base/logging.cc:57: #if defined(OS_MACOSX) I think the ...

10 years ago (2010-12-14 00:03:43 UTC) #2

stuartmorgan

10 years ago (2010-12-14 00:04:19 UTC) #3

LGTM with include change.

http://codereview.chromium.org/5804004/diff/2001/base/logging.cc
File base/logging.cc (right):

http://codereview.chromium.org/5804004/diff/2001/base/logging.cc#newcode57
base/logging.cc:57: #if defined(OS_MACOSX)
I can't find the email now, but the recollection of people I polled here is that
the consensus for this kind of thing was a single block at the end for platform
includes, which is internally ordered alphabetically.

Expand Messages | Collapse Messages

Issue 5804004: Add Debug Message Dialog Support for Mac OS (Closed)

Description

Patch Set 1 #

Patch Set 2 : alphabet issues #

Messages