Chromium Code Reviews

Issue 5804004: Add Debug Message Dialog Support for Mac OS (Closed)

Created:
10 years ago by dmac
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan, Nico, viettrungluu
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Add Debug Message Dialog Support for Mac OS BUG=37026 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69138

Patch Set 1 #

Patch Set 2 : alphabet issues #

Total comments: 2
Unified diffs Side-by-side diffs Stats (+12 lines, -0 lines)
M base/logging.cc View 2 chunks +12 lines, -0 lines 2 comments

Messages

Total messages: 3 (0 generated)
dmac
Sharing the love with everybody....
10 years ago (2010-12-13 23:50:53 UTC) #1
viettrungluu
LGTM with tiny nit. http://codereview.chromium.org/5804004/diff/2001/base/logging.cc File base/logging.cc (right): http://codereview.chromium.org/5804004/diff/2001/base/logging.cc#newcode57 base/logging.cc:57: #if defined(OS_MACOSX) I think the ...
10 years ago (2010-12-14 00:03:43 UTC) #2
stuartmorgan
10 years ago (2010-12-14 00:04:19 UTC) #3 
LGTM with include change.

http://codereview.chromium.org/5804004/diff/2001/base/logging.cc
File base/logging.cc (right):

http://codereview.chromium.org/5804004/diff/2001/base/logging.cc#newcode57
base/logging.cc:57: #if defined(OS_MACOSX)
I can't find the email now, but the recollection of people I polled here is that
the consensus for this kind of thing was a single block at the end for platform
includes, which is internally ordered alphabetically.

Powered by Google App Engine