Issue 5802004: Fix 'else' style nit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5802004: Fix 'else' style nit. (Closed)

Created:
10 years ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe, mbelshe

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix 'else' style nit. R=mbelshe BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69339

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	net/spdy/spdy_session.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mbelshe

10 years ago (2010-12-14 19:37:57 UTC) #2

lgtm

On Tue, Dec 14, 2010 at 11:21 AM, <wtc@chromium.org> wrote:

> Reviewers: Mike Belshe,
>
> Description:
> Fix 'else' style nit.
>
> R=mbelshe
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/5802004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     net/spdy/spdy_session.cc
>
>
> Index: net/spdy/spdy_session.cc
> ===================================================================
> --- net/spdy/spdy_session.cc    (revision 68922)
> +++ net/spdy/spdy_session.cc    (working copy)
> @@ -937,9 +937,7 @@
>     used_push_streams.Increment();
>     return stream;
>   }
> -  else {
> -    return NULL;
> -  }
> +  return NULL;
>  }
>
>  bool SpdySession::GetSSLInfo(SSLInfo* ssl_info, bool* was_npn_negotiated)
> {
>
>
>

Expand Messages | Collapse Messages