Issue 5802003: touchui: Improve key-event processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5802003: touchui: Improve key-event processing. (Closed)

Created:
10 years ago by sadrul

Modified:
9 years, 6 months ago

Reviewers:
rjkroege, sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

touchui: Improve key-event processing. Add more keycode translations from X events to views events. BUG=None TEST=Pressing keys such as ,./;'<> etc. should show up correctly in a webpage. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69012

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -5 lines)			Patch
	M	app/keyboard_code_conversion_x.cc	View		4 chunks	+123 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rjkroege

LGTM. It would probably be a godo idea to send it to sky as well.

10 years ago (2010-12-13 15:42:21 UTC) #2

LGTM

Expand Messages | Collapse Messages