Issue 5802001: Remove deprecated repos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5802001: Remove deprecated repos (Closed)

Created:
10 years ago by anush

Modified:
9 years, 7 months ago

Reviewers:
davidjames, scottz, djmm

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org:9222/manifest@master

Visibility:
Public.

Description

Remove deprecated repos BUG=10187 TEST=verify full/mini checkouts Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ea34346

Patch Set 1 #

Total comments: 4

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -19 lines)			Patch
	M	minilayout.xml	View		1 chunk	+24 lines, -7 lines	2 comments	Download
	M	oldlayout.xml	View		4 chunks	+25 lines, -12 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

davidjames

LGTM w/nits http://codereview.chromium.org/5802001/diff/1/minilayout.xml File minilayout.xml (right): http://codereview.chromium.org/5802001/diff/1/minilayout.xml#newcode33 minilayout.xml:33: <project path="src/third_party/chromiumos-overlay" name="chromiumos-overlay" > No need for ...

10 years ago (2010-12-11 02:19:39 UTC) #2

scottz

10 years ago (2010-12-13 19:23:54 UTC) #3

http://codereview.chromium.org/5802001/diff/1/minilayout.xml
File minilayout.xml (right):

http://codereview.chromium.org/5802001/diff/1/minilayout.xml#newcode33
minilayout.xml:33: <project path="src/third_party/chromiumos-overlay"
name="chromiumos-overlay" >
actually don't you need a />?

http://codereview.chromium.org/5802001/diff/1/oldlayout.xml
File oldlayout.xml (right):

http://codereview.chromium.org/5802001/diff/1/oldlayout.xml#newcode109
oldlayout.xml:109: <project path="src/third_party/chromiumos-overlay"
name="chromiumos-overlay" >
same as before don't you need a /> ?

Expand Messages | Collapse Messages