Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/api.cc

Issue 58016: Fix v8::Object::DeleteHiddenValue to not bail when there are no hidden proper... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2059 matching lines...) Expand 10 before | Expand all | Expand 10 after
2070 return v8::Local<v8::Value>(); 2070 return v8::Local<v8::Value>();
2071 } 2071 }
2072 return Utils::ToLocal(result); 2072 return Utils::ToLocal(result);
2073 } 2073 }
2074 2074
2075 2075
2076 bool v8::Object::DeleteHiddenValue(v8::Handle<v8::String> key) { 2076 bool v8::Object::DeleteHiddenValue(v8::Handle<v8::String> key) {
2077 ON_BAILOUT("v8::DeleteHiddenValue()", return false); 2077 ON_BAILOUT("v8::DeleteHiddenValue()", return false);
2078 ENTER_V8; 2078 ENTER_V8;
2079 i::Handle<i::JSObject> self = Utils::OpenHandle(this); 2079 i::Handle<i::JSObject> self = Utils::OpenHandle(this);
2080 i::Handle<i::JSObject> hidden_props( 2080 i::Handle<i::Object> hidden_props(i::GetHiddenProperties(self, false));
2081 i::JSObject::cast(*i::GetHiddenProperties(self, false)));
2082 if (hidden_props->IsUndefined()) { 2081 if (hidden_props->IsUndefined()) {
2083 return false; 2082 return true;
2084 } 2083 }
2084 i::Handle<i::JSObject> js_obj(i::JSObject::cast(*hidden_props));
2085 i::Handle<i::String> key_obj = Utils::OpenHandle(*key); 2085 i::Handle<i::String> key_obj = Utils::OpenHandle(*key);
2086 return i::DeleteProperty(hidden_props, key_obj)->IsTrue(); 2086 return i::DeleteProperty(js_obj, key_obj)->IsTrue();
2087 } 2087 }
2088 2088
2089 2089
2090 Local<v8::Object> Function::NewInstance() const { 2090 Local<v8::Object> Function::NewInstance() const {
2091 return NewInstance(0, NULL); 2091 return NewInstance(0, NULL);
2092 } 2092 }
2093 2093
2094 2094
2095 Local<v8::Object> Function::NewInstance(int argc, 2095 Local<v8::Object> Function::NewInstance(int argc,
2096 v8::Handle<v8::Value> argv[]) const { 2096 v8::Handle<v8::Value> argv[]) const {
(...skipping 1242 matching lines...) Expand 10 before | Expand all | Expand 10 after
3339 reinterpret_cast<HandleScopeImplementer*>(storage); 3339 reinterpret_cast<HandleScopeImplementer*>(storage);
3340 List<void**>* blocks_of_archived_thread = thread_local->Blocks(); 3340 List<void**>* blocks_of_archived_thread = thread_local->Blocks();
3341 v8::ImplementationUtilities::HandleScopeData* handle_data_of_archived_thread = 3341 v8::ImplementationUtilities::HandleScopeData* handle_data_of_archived_thread =
3342 &thread_local->handle_scope_data_; 3342 &thread_local->handle_scope_data_;
3343 Iterate(v, blocks_of_archived_thread, handle_data_of_archived_thread); 3343 Iterate(v, blocks_of_archived_thread, handle_data_of_archived_thread);
3344 3344
3345 return storage + ArchiveSpacePerThread(); 3345 return storage + ArchiveSpacePerThread();
3346 } 3346 }
3347 3347
3348 } } // namespace v8::internal 3348 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698