Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 58016: Fix v8::Object::DeleteHiddenValue to not bail when there are no hidden proper... (Closed)

Created:
11 years, 8 months ago by asargent_no_longer_on_chrome
Modified:
9 years, 7 months ago
Reviewers:
iposva
CC:
v8-dev
Visibility:
Public.

Description

Fix v8::Object::DeleteHiddenValue to not bail when there are no hidden properties. Also make it return true even if there was nothing to delete, to match the behavior of v8::Object::Delete. This is to fix http://code.google.com/p/v8/issues/detail?id=300

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/api.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
asargent_no_longer_on_chrome
11 years, 8 months ago (2009-04-08 03:48:41 UTC) #1
iposva
One comment, otherwise LGTM! Thanks, -Ivan http://codereview.chromium.org/58016/diff/1/2 File src/api.cc (right): http://codereview.chromium.org/58016/diff/1/2#newcode2085 Line 2085: if (js_object->IsUndefined()) ...
11 years, 8 months ago (2009-04-08 04:52:04 UTC) #2
asargent_no_longer_on_chrome
11 years, 8 months ago (2009-04-08 20:28:26 UTC) #3
http://codereview.chromium.org/58016/diff/1/2
File src/api.cc (right):

http://codereview.chromium.org/58016/diff/1/2#newcode2085
Line 2085: if (js_object->IsUndefined()) {
On 2009/04/08 04:52:04, iposva wrote:
> This test seems redundant. hidden_props has to be !undefined to reach here,
and
> the cast from i::Object to i::JSObject is definitely not going to make an
> undefined value.

Done.

I also renamed 'js_object' to 'js_obj' to better match the surrounding code's
naming conventions.

Powered by Google App Engine
This is Rietveld 408576698