Issue 5801003: Fix passphrase initialization flow in ProfileSyncServiceHarness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5801003: Fix passphrase initialization flow in ProfileSyncServiceHarness (Closed)

Created:
10 years ago by Raghu Simha

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, ncarter (slow), idana, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix passphrase initialization flow in ProfileSyncServiceHarness There was a race condition in ProfileSyncServiceHarness due to its multiple inheritance of ProfileSyncServiceObserver and NotificationObserver, causing several integration tests to fail. This patch contains a fix that involves not inheriting from NotificationObserver, and simply relying on the OnStateChanged() mechanism of ProfileSyncServiceObserver, thereby eliminating the race. It also contains 2 new test cases that further verify passphrase functionality: SetPassphraseAndThenSetupSync and SetPassphraseTwice. BUG=64109 TEST=sync_integration_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69203

Patch Set 1 #

Patch Set 2 : Adding 2 new tests for Passphrases. #

Created: 10 years ago

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -50 lines)
M	chrome/browser/sync/profile_sync_service_harness.h	View	5 chunks	+1 line, -17 lines	0 comments
M	chrome/browser/sync/profile_sync_service_harness.cc	View	5 chunks	+9 lines, -33 lines	0 comments
M	chrome/test/live_sync/two_client_live_passwords_sync_test.cc	View	1 chunk	+46 lines, -0 lines	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

On 2010/12/14 23:13:43, rsimha wrote: > Added 2 new tests. Please review once again. Thanks. ...

10 years ago (2010-12-15 00:06:46 UTC) #3

Raghu Simha

10 years ago (2010-12-15 00:08:20 UTC) #4

On 2010/12/15 00:06:46, timsteele wrote:
> On 2010/12/14 23:13:43, rsimha wrote:
> > Added 2 new tests. Please review once again. Thanks.
> 
> LGTM, take a peek at the test failures on linux_sync

Thanks. Re: the failures, I talked to Fred; they're due to testserver flakiness
and have nothing to do with passphrases.

Expand Messages | Collapse Messages