Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 5801001: Fix cros_run_vm_update --proxy_port support (Closed)

Created:
10 years ago by dgarrett
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Fix cros_run_vm_update --proxy_port support BUG=chromium-os:10318 TEST=Manual Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=fdefe86

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix " nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M bin/cros_run_vm_update View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dgarrett
10 years ago (2010-12-11 00:14:41 UTC) #1
sosa
http://codereview.chromium.org/5801001/diff/1/bin/cros_run_vm_update File bin/cros_run_vm_update (right): http://codereview.chromium.org/5801001/diff/1/bin/cros_run_vm_update#newcode44 bin/cros_run_vm_update:44: IMAGE_ARGS="--proxy_port="${FLAGS_proxy_port}"" Does the quotes in quotes work? Don't need ...
10 years ago (2010-12-11 00:17:07 UTC) #2
dgarrett
http://codereview.chromium.org/5801001/diff/1/bin/cros_run_vm_update File bin/cros_run_vm_update (right): http://codereview.chromium.org/5801001/diff/1/bin/cros_run_vm_update#newcode44 bin/cros_run_vm_update:44: IMAGE_ARGS="--proxy_port="${FLAGS_proxy_port}"" On 2010/12/11 00:17:07, sosa wrote: > Does the ...
10 years ago (2010-12-11 00:25:38 UTC) #3
sosa
10 years ago (2010-12-11 00:34:01 UTC) #4
Ah makes sense.  LGTM

On Fri, Dec 10, 2010 at 4:25 PM,  <dgarrett@chromium.org> wrote:
>
> http://codereview.chromium.org/5801001/diff/1/bin/cros_run_vm_update
> File bin/cros_run_vm_update (right):
>
> http://codereview.chromium.org/5801001/diff/1/bin/cros_run_vm_update#newcode44
> bin/cros_run_vm_update:44:
> IMAGE_ARGS="--proxy_port="${FLAGS_proxy_port}""
> On 2010/12/11 00:17:07, sosa wrote:
>>
>> Does the quotes in quotes work?  Don't need \" in there?
>
> To be honest, it's a copy mod of the option above. It does work, but is
> probably suboptimal. I imagine it's just being passed along to a new
> shell that processes it out.
>
> http://codereview.chromium.org/5801001/
>

Powered by Google App Engine
This is Rietveld 408576698