Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 58008: Replace webkit/glue/screen_info.h with WebKit/chromium/public/WebScreenInfo.h... (Closed)

Created:
11 years, 8 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Replace webkit/glue/screen_info.h with WebKit/chromium/public/WebScreenInfo.h This also eliminates webkit_glue::GetScreenInfo and webkit_glue::GetScreenInfoHelper. As part of this CL, I also extracted all of the ParamTraits for WebKit API types into chrome/common/webkit_param_traits.h. R=dglazkov Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12993

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -2280 lines) Patch
M chrome/browser/renderer_host/resource_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 2 chunks +15 lines, -3 lines 1 comment Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/common.scons View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/common.vcproj View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 7 chunks +1 line, -241 lines 0 comments Download
M chrome/common/render_messages_internal.h View 2 chunks +5 lines, -4 lines 0 comments Download
A + chrome/common/webkit_param_traits.h View 1 4 chunks +79 lines, -1801 lines 0 comments Download
M chrome/renderer/render_widget.h View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/renderer/render_widget.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_glue.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/worker/test_worker_main.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/build/WebKit/WebKit.vcproj View 2 chunks +8 lines, -0 lines 0 comments Download
M webkit/glue/SConscript View 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/glue/chromium_bridge_impl.cc View 4 chunks +33 lines, -8 lines 0 comments Download
M webkit/glue/glue.vcproj View 1 chunk +0 lines, -4 lines 0 comments Download
D webkit/glue/screen_info.h View 1 chunk +0 lines, -39 lines 0 comments Download
M webkit/glue/webkit_glue.h View 3 chunks +0 lines, -9 lines 0 comments Download
D webkit/glue/webkit_glue_gtk.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D webkit/glue/webkit_glue_mac.mm View 1 chunk +0 lines, -69 lines 0 comments Download
D webkit/glue/webkit_glue_win.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M webkit/glue/webview_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webwidget_delegate.h View 2 chunks +10 lines, -3 lines 0 comments Download
M webkit/glue/webwidget_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/mac/webwidget_host.mm View 3 chunks +8 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 3 chunks +11 lines, -1 line 0 comments Download
M webkit/tools/test_shell/webwidget_host.h View 2 chunks +6 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/webwidget_host_gtk.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/webwidget_host_win.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M webkit/webkit.gyp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
http://codereview.chromium.org/58008/diff/2001/2004 File chrome/browser/renderer_host/resource_message_filter.cc (right): http://codereview.chromium.org/58008/diff/2001/2004#newcode45 Line 45: #if defined(OS_WIN) This is where not having a ...
11 years, 8 months ago (2009-04-01 20:28:54 UTC) #1
dglazkov
11 years, 8 months ago (2009-04-01 20:47:38 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698