Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2171)

Unified Diff: WebCore/ChangeLog

Issue 5800002: Merge 73697 - 2010-12-10 Hans Wennborg <hans@chromium.org>... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/597/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/storage/indexeddb/objectstore-cursor.html ('k') | WebCore/bindings/v8/IDBBindingUtilities.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 73901)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,1054 @@
+2010-12-10 Hans Wennborg <hans@chromium.org>
+
+ Reviewed by Jeremy Orlow.
+
+ IndexedDB: Numeric keys are floats.
+ https://bugs.webkit.org/show_bug.cgi?id=50674
+
+ Use floating point to represent numeric keys,
+ add version meta data to the SQLite db,
+ and migrate object stores that use integers.
+
+ * bindings/v8/IDBBindingUtilities.cpp:
+ (WebCore::createIDBKeyFromValue):
+ * bindings/v8/custom/V8IDBKeyCustom.cpp:
+ (WebCore::toV8):
+ * storage/IDBFactoryBackendImpl.cpp:
+ (WebCore::createTables):
+ (WebCore::migrateDatabase):
+ (WebCore::IDBFactoryBackendImpl::open):
+ * storage/IDBKey.cpp:
+ (WebCore::IDBKey::IDBKey):
+ (WebCore::IDBKey::fromQuery):
+ (WebCore::IDBKey::bind):
+ (WebCore::IDBKey::bindWithNulls):
+ * storage/IDBKey.h:
+ (WebCore::IDBKey::create):
+ (WebCore::IDBKey::number):
+
+2010-12-10 Martin Robinson <mrobinson@igalia.com>
+
+ Reviewed by Xan Lopez.
+
+ [Gtk] style="font-family: courier" makes text disappear
+ https://bugs.webkit.org/show_bug.cgi?id=47452
+
+ Don't ever use fonts that do not have any of the three charmaps that
+ Fontconfig supports (Unicode, Apple Roman and Symbol). If we select
+ a font that doesn't have one of these charmaps, use the next font in
+ the list.
+
+ Test: platform/gtk/fonts/font-with-no-valid-encoding.html
+
+ * platform/graphics/freetype/FontCacheFreeType.cpp:
+ (WebCore::FontCache::createFontPlatformData): Check whether the
+ font we selected has a valid Fontconfig charmap.
+ * platform/graphics/freetype/FontPlatformData.h: Added new method definition.
+ * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
+ (WebCore::FontPlatformData::hasCompatibleCharmap): Added this method which
+ verifies that a font has a valid Fontconfig charmap.
+
+2010-12-09 Ryosuke Niwa <rniwa@webkit.org>
+
+ Reviewed by Ojan Vafai.
+
+ Make DOM Mutation Events Asynchronous
+ https://bugs.webkit.org/show_bug.cgi?id=46936
+
+ Implemented DOM mutations events as scoped events. A scoped event is an event whose
+ dispatch is done via ScopedEventQueue. The behavior of the queue is controlled by
+ EventQueueScope objects (RAII idiom), which increments and decrements the scoping level
+ on its constructor and destructor respectively.
+
+ When the scoping level is 0 (initial level), scoped events are dispatched as soon as
+ they are enqueued and act like synchronous events. When the scoping level is greater than 0,
+ however, events are queued in ScopedEventQueue and their dispatches are delayed until
+ the scoping level goes back to 0 (by the destruction of EventQueueScope).
+
+ DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromDocument,
+ DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focusout are treated as
+ scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches
+ of the events until the completion of each call of EditCommand::doApply.
+
+ Test: fast/events/mutation/execCommands.html
+
+ * Android.mk: Added ScopedEventQueue.cpp.
+ * CMakeLists.txt: Ditto.
+ * WebCore.pro: Ditto.
+ * GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h.
+ * WebCore.gypi: Ditto.
+ * WebCore.vcproj/project.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * dom/ContainerNode.cpp:
+ (WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent.
+ (WebCore::dispatchChildRemovalEvents): Ditto.
+ * dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp.
+ * dom/Element.cpp:
+ (WebCore::Element::dispatchAttrRemovalEvent): Ditto.
+ (WebCore::Element::dispatchAttrAdditionEvent): Ditto.
+ * dom/Node.cpp:
+ (WebCore::Node::dispatchScopedEvent): Added.
+ (WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent.
+ * dom/Node.h:
+ * dom/ScopedEventQueue.cpp: Added.
+ (WebCore::ScopedEventQueue::initialize): Added.
+ (WebCore::ScopedEventQueue::enqueueEvent): Added.
+ (WebCore::ScopedEventQueue::dispatchAllEvents): Added.
+ (WebCore::ScopedEventQueue::dispatchEvent): Added.
+ (WebCore::ScopedEventQueue::instance): Added.
+ (WebCore::ScopedEventQueue::incrementScopingLevel): Added.
+ (WebCore::ScopedEventQueue::decrementScopingLevel): Added.
+ * dom/ScopedEventQueue.h: Added.
+ (WebCore::ScopedEventQueue::~ScopedEventQueue): Added.
+ (WebCore::ScopedEventQueue::ScopedEventQueue): Added.
+ (WebCore::EventQueueScope::EventQueueScope): Added.
+ (WebCore::EventQueueScope::~EventQueueScope): Added.
+ * editing/EditCommand.cpp:
+ (WebCore::EditCommand::apply): Instantiates EventQueueScope.
+
+2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
+
+ Unreviewed, rolling out r73684.
+ http://trac.webkit.org/changeset/73684
+ https://bugs.webkit.org/show_bug.cgi?id=50801
+
+ "missing bug number" (Requested by rniwa on #webkit).
+
+ * Android.mk:
+ * CMakeLists.txt:
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/ContainerNode.cpp:
+ (WebCore::dispatchChildInsertionEvents):
+ (WebCore::dispatchChildRemovalEvents):
+ * dom/DOMAllInOne.cpp:
+ * dom/Element.cpp:
+ (WebCore::Element::dispatchAttrRemovalEvent):
+ (WebCore::Element::dispatchAttrAdditionEvent):
+ * dom/Node.cpp:
+ (WebCore::Node::dispatchSubtreeModifiedEvent):
+ (WebCore::Node::dispatchUIEvent):
+ * dom/Node.h:
+ * dom/ScopedEventQueue.cpp: Removed.
+ * dom/ScopedEventQueue.h: Removed.
+ * editing/EditCommand.cpp:
+ (WebCore::EditCommand::apply):
+
+2010-12-09 Qi Zhang <qi.2.zhang@nokia.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] enable orientation flag when QtMobility available
+ https://bugs.webkit.org/show_bug.cgi?id=50781
+
+ When QtMobility available, enable orientation flag by default.
+
+ * features.pri:
+
+2010-12-09 Kenichi Ishibashi <bashi@google.com>
+
+ Reviewed by Kent Tamura.
+
+ Improve validation API support of <object> and <keygen>
+ https://bugs.webkit.org/show_bug.cgi?id=50663
+
+ Adds validation API to HTMLObjectElement class.
+ Makes HTMLKeygenElement::willValidate() return false.
+
+ Test: fast/forms/setCustomValidity-existence.html
+
+ * html/HTMLKeygenElement.h:
+ (WebCore::HTMLKeygenElement::willValidate): Added.
+ * html/HTMLObjectElement.h:
+ (WebCore::HTMLObjectElement::validationMessage): Added.
+ (WebCore::HTMLObjectElement::checkValidity): Added.
+ (WebCore::HTMLObjectElement::setCustomValidity): Added.
+ * html/HTMLObjectElement.idl: Added validation API properties.
+
+2010-12-09 Sadrul Habib Chowdhury <sadrul@chromium.org>
+
+ Reviewed by Kent Tamura.
+
+ Make sure a non-zero value is used for tile-width to avoid a crash
+ https://bugs.webkit.org/show_bug.cgi?id=50341
+
+ The scaled tile width can be very small at times (e.g. with 'style: font 1
+ required'). So use a minimum width of 1 instead of using 0 (which leads to a
+ crash).
+
+ Tests: fast/dom/HTMLProgressElement/progress-element-with-style-crash.html
+
+ * rendering/RenderThemeChromiumSkia.cpp:
+ (WebCore::RenderThemeChromiumSkia::paintProgressBar):
+
+2010-12-09 Ryosuke Niwa <rniwa@webkit.org>
+
+ Reviewed by Ojan Vafai.
+
+ Implemented DOM mutations events as scoped events. A scoped event is an event whose
+ dispatch is done via ScopedEventQueue. The behavior of the queue is controlled by
+ EventQueueScope objects (RAII idiom), which increments and decrements the scoping level
+ on its constructor and destructor respectively.
+
+ When the scoping level is 0 (initial level), scoped events are dispatched as soon as
+ they are enqueued and act like synchronous events. When the scoping level is greater than 0,
+ however, events are queued in ScopedEventQueue and their dispatches are delayed until
+ the scoping level goes back to 0 (by the destruction of EventQueueScope).
+
+ DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromDocument,
+ DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focusout are treated as
+ scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches
+ of the events until the completion of each call of EditCommand::doApply.
+
+ Test: fast/events/mutation/execCommands.html
+
+ * Android.mk: Added ScopedEventQueue.cpp.
+ * CMakeLists.txt: Ditto.
+ * WebCore.pro: Ditto.
+ * GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h.
+ * WebCore.gypi: Ditto.
+ * WebCore.vcproj/project.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * dom/ContainerNode.cpp:
+ (WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent.
+ (WebCore::dispatchChildRemovalEvents): Ditto.
+ * dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp.
+ * dom/Element.cpp:
+ (WebCore::Element::dispatchAttrRemovalEvent): Ditto.
+ (WebCore::Element::dispatchAttrAdditionEvent): Ditto.
+ * dom/Node.cpp:
+ (WebCore::Node::dispatchScopedEvent): Added.
+ (WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent.
+ * dom/Node.h:
+ * dom/ScopedEventQueue.cpp: Added.
+ (WebCore::ScopedEventQueue::initialize): Added.
+ (WebCore::ScopedEventQueue::enqueueEvent): Added.
+ (WebCore::ScopedEventQueue::dispatchAllEvents): Added.
+ (WebCore::ScopedEventQueue::dispatchEvent): Added.
+ (WebCore::ScopedEventQueue::instance): Added.
+ (WebCore::ScopedEventQueue::incrementScopingLevel): Added.
+ (WebCore::ScopedEventQueue::decrementScopingLevel): Added.
+ * dom/ScopedEventQueue.h: Added.
+ (WebCore::ScopedEventQueue::~ScopedEventQueue): Added.
+ (WebCore::ScopedEventQueue::ScopedEventQueue): Added.
+ (WebCore::EventQueueScope::EventQueueScope): Added.
+ (WebCore::EventQueueScope::~EventQueueScope): Added.
+ * editing/EditCommand.cpp:
+ (WebCore::EditCommand::apply): Instantiates EventQueueScope.
+
+2010-12-09 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Gavin Barraclough.
+
+ Fix scrolling with mouse wheel in WebKit2 views. Once
+ we coalesce wheel events, we can re-enable this.
+
+ * platform/mac/ScrollAnimatorMac.mm:
+ (WebCore::ScrollAnimatorMac::scroll):
+
+2010-12-09 Abhishek Arya <inferno@chromium.org>
+
+ Reviewed by James Robinson.
+
+ For details element, ensure that if we ended up being inline that we set out replaced
+ flag so that we are treated like an inline block.
+ https://bugs.webkit.org/show_bug.cgi?id=50671
+
+ Test: fast/html/details-element-render-inline-crash.html
+
+ * rendering/RenderDetails.cpp:
+ (WebCore::RenderDetails::styleDidChange): setReplaced to true if we are set as inline.
+ * rendering/RenderDetails.h: function definition.
+
+2010-12-09 Jasmin Lapalme <jlapalme@druide.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Fix a faulty conversion from UTF-8 to UTF-16 in WebCore during an XSLT transformation.
+ https://bugs.webkit.org/show_bug.cgi?id=50708
+
+ Test: fast/xsl/utf8-chunks.xml
+
+ * xml/XSLTProcessorLibxslt.cpp:
+ (WebCore::writeToVector): now converts and returns the correct byte count when the end of the chunk is in the middle of a multibyte UTF-8 character.
+
+2010-12-09 Vincent Scheib <scheib@chromium.org>
+
+ Reviewed by James Robinson.
+
+ Clip update rectangle for Texture::updateSubRect to texture size
+ https://bugs.webkit.org/show_bug.cgi?id=49929
+
+ Test: fast/canvas/canvas-largedraws.html
+
+ * platform/graphics/gpu/Texture.cpp:
+ (WebCore::Texture::updateSubRect):
+
+2010-12-09 Kenneth Russell <kbr@google.com>
+
+ Unreviewed. Another speculative Gtk build fix after r73669. Add
+ needed derived sources to GNUmakefile.am.
+
+ * GNUmakefile.am:
+
+2010-12-09 Kenneth Russell <kbr@google.com>
+
+ Unreviewed. Speculative Gtk build fix after
+ https://bugs.webkit.org/show_bug.cgi?id=36512 / r73669. Process
+ all of the WebGL classes' IDL files.
+
+ * CMakeLists.txt:
+
+2010-12-09 Zhenyao Mo <zmo@google.com>
+
+ Reviewed by Kenneth Russell.
+
+ Expose constructor functions for instanceof checks of WebGL objects
+ https://bugs.webkit.org/show_bug.cgi?id=36512
+
+ Test: fast/canvas/webgl/instanceof-test.html
+
+ * bindings/generic/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::webGLActiveInfoEnabled):
+ (WebCore::RuntimeEnabledFeatures::webGLBufferEnabled):
+ (WebCore::RuntimeEnabledFeatures::webGLFramebufferEnabled):
+ (WebCore::RuntimeEnabledFeatures::webGLProgramEnabled):
+ (WebCore::RuntimeEnabledFeatures::webGLRenderbufferEnabled):
+ (WebCore::RuntimeEnabledFeatures::webGLShaderEnabled):
+ (WebCore::RuntimeEnabledFeatures::webGLTextureEnabled):
+ (WebCore::RuntimeEnabledFeatures::webGLUniformLocationEnabled):
+ * html/canvas/WebGLActiveInfo.idl: Remove OmitConstructor.
+ * html/canvas/WebGLBuffer.idl: Ditto.
+ * html/canvas/WebGLFramebuffer.idl: Ditto.
+ * html/canvas/WebGLProgram.idl: Ditto.
+ * html/canvas/WebGLRenderbuffer.idl: Ditto.
+ * html/canvas/WebGLShader.idl: Ditto.
+ * html/canvas/WebGLTexture.idl: Ditto.
+ * html/canvas/WebGLUniformLocation.idl: Ditto.
+ * page/DOMWindow.idl: Expose constructors for WebGL objects in DOMWindow.
+
+2010-12-09 Timothy Hatcher <timothy@apple.com>
+
+ Export Color::white and Color::transparent.
+
+ Reviewed by Anders Carlsson.
+
+ * WebCore.exp.in:
+
+2010-12-09 Sam Weinig <sam@webkit.org>
+
+ Fix failing Mac tests.
+
+ * platform/mac/ScrollAnimatorMac.mm:
+ (WebCore::ScrollAnimatorMac::scroll): Don't smooth scroll if the default
+ AppleScrollAnimationEnabled is false.
+
+2010-12-09 James Robinson <jamesr@chromium.org>
+
+ Reviewed by Kenneth Russell.
+
+ [chromium] Compositor needs to manage its VRAM use
+ https://bugs.webkit.org/show_bug.cgi?id=49629
+
+ This adds a basic texture manager to the Chromium compositor to limit the amount of VRAM
+ used by compositor textures and switches ContentLayerChromium, ImageLayerChromium, and
+ RenderSurfaceChromium to use managed LayerTexture. The other *LayerChromium classes (Canvas,
+ Video, and WebGL) and the root layer are still unmanaged.
+
+ The TextureManager works by providing tokens to callers that want to use a managed texture.
+ The token can be used to request a texture, see if the previously requested texture is still
+ available, and to protect/unprotect textures when they cannot be collected. Whenever a
+ texture is created the manager attempts to free up the least recently used textures until the
+ total memory use is below the provided threshhold. If the manager cannot satisfy the memory
+ limit it will not return any new textures until some old textures are released.
+
+ A LayerTexture wraps a TextureManager token, size, and format. A LayerChromium can check if a
+ previously requested texture is still available for use and reserve the LayerTexture's underlying
+ storage between the updateContentsIfDirty() and the draw() call.
+
+ Also changes LayerChromium from having separate contentsDirty()/updateContents() calls to a single
+ updateContentsIfDirty().
+
+ Tests: platform/chromium/compositing/lots-of-img-layers-with-opacity.html
+ platform/chromium/compositing/lots-of-img-layers.html
+
+ * WebCore.gypi:
+ * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
+ (WebCore::Canvas2DLayerChromium::updateContentsIfDirty):
+ * platform/graphics/chromium/Canvas2DLayerChromium.h:
+ * platform/graphics/chromium/ContentLayerChromium.cpp:
+ (WebCore::ContentLayerChromium::cleanupResources):
+ (WebCore::ContentLayerChromium::updateContentsIfDirty):
+ (WebCore::ContentLayerChromium::updateTextureRect):
+ (WebCore::ContentLayerChromium::draw):
+ * platform/graphics/chromium/ContentLayerChromium.h:
+ * platform/graphics/chromium/ImageLayerChromium.cpp:
+ (WebCore::ImageLayerChromium::updateContentsIfDirty):
+ * platform/graphics/chromium/ImageLayerChromium.h:
+ * platform/graphics/chromium/LayerChromium.h:
+ (WebCore::LayerChromium::updateContentsIfDirty):
+ (WebCore::LayerChromium::draw):
+ * platform/graphics/chromium/LayerRendererChromium.cpp:
+ (WebCore::LayerRendererChromium::LayerRendererChromium):
+ (WebCore::LayerRendererChromium::useShader):
+ (WebCore::LayerRendererChromium::prepareToDrawLayers):
+ (WebCore::LayerRendererChromium::updateRootLayerTextureRect):
+ (WebCore::LayerRendererChromium::drawLayers):
+ (WebCore::LayerRendererChromium::getFramebufferPixels):
+ (WebCore::LayerRendererChromium::createLayerTexture):
+ (WebCore::LayerRendererChromium::deleteLayerTexture):
+ (WebCore::LayerRendererChromium::updateLayersRecursive):
+ (WebCore::LayerRendererChromium::useRenderSurface):
+ (WebCore::LayerRendererChromium::drawLayer):
+ (WebCore::LayerRendererChromium::setScissorToRect):
+ (WebCore::LayerRendererChromium::setDrawViewportRect):
+ (WebCore::LayerRendererChromium::initializeSharedObjects):
+ (WebCore::LayerRendererChromium::cleanupSharedObjects):
+ * platform/graphics/chromium/LayerRendererChromium.h:
+ (WebCore::LayerRendererChromium::renderSurfaceSharedValues):
+ (WebCore::LayerRendererChromium::textureManager):
+ * platform/graphics/chromium/LayerTexture.cpp: Added.
+ (WebCore::LayerTexture::LayerTexture):
+ (WebCore::LayerTexture::~LayerTexture):
+ (WebCore::LayerTexture::isValid):
+ (WebCore::LayerTexture::reserve):
+ (WebCore::LayerTexture::unreserve):
+ (WebCore::LayerTexture::bindTexture):
+ (WebCore::LayerTexture::framebufferTexture2D):
+ * platform/graphics/chromium/LayerTexture.h: Added.
+ (WebCore::LayerTexture::create):
+ * platform/graphics/chromium/PluginLayerChromium.cpp:
+ (WebCore::PluginLayerChromium::updateContentsIfDirty):
+ * platform/graphics/chromium/PluginLayerChromium.h:
+ * platform/graphics/chromium/RenderSurfaceChromium.cpp:
+ (WebCore::RenderSurfaceChromium::SharedValues::SharedValues):
+ (WebCore::RenderSurfaceChromium::SharedValues::~SharedValues):
+ (WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
+ (WebCore::RenderSurfaceChromium::cleanupResources):
+ (WebCore::RenderSurfaceChromium::prepareContentsTexture):
+ (WebCore::RenderSurfaceChromium::draw):
+ * platform/graphics/chromium/RenderSurfaceChromium.h:
+ (WebCore::RenderSurfaceChromium::SharedValues::shaderProgram):
+ (WebCore::RenderSurfaceChromium::SharedValues::shaderSamplerLocation):
+ (WebCore::RenderSurfaceChromium::SharedValues::shaderMatrixLocation):
+ (WebCore::RenderSurfaceChromium::SharedValues::shaderAlphaLocation):
+ (WebCore::RenderSurfaceChromium::SharedValues::initialized):
+ * platform/graphics/chromium/TextureManager.cpp: Added.
+ (WebCore::memoryUseBytes):
+ (WebCore::TextureManager::TextureManager):
+ (WebCore::TextureManager::getToken):
+ (WebCore::TextureManager::releaseToken):
+ (WebCore::TextureManager::hasTexture):
+ (WebCore::TextureManager::protectTexture):
+ (WebCore::TextureManager::unprotectTexture):
+ (WebCore::TextureManager::reduceMemoryToLimit):
+ (WebCore::TextureManager::addTexture):
+ (WebCore::TextureManager::removeTexture):
+ (WebCore::TextureManager::requestTexture):
+ * platform/graphics/chromium/TextureManager.h: Added.
+ (WebCore::TextureManager::create):
+ * platform/graphics/chromium/VideoLayerChromium.cpp:
+ (WebCore::VideoLayerChromium::updateContentsIfDirty):
+ * platform/graphics/chromium/VideoLayerChromium.h:
+ * platform/graphics/chromium/WebGLLayerChromium.cpp:
+ (WebCore::WebGLLayerChromium::updateContentsIfDirty):
+ * platform/graphics/chromium/WebGLLayerChromium.h:
+
+2010-12-09 Darin Adler <darin@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ Rework my recent setLocation refactoring to use DOMWindow instead of Frame.
+ It's difficult to make correct security decisions based on Frame since a
+ Frame can navigate to a new document.
+
+ Fixes some test failures that I somehow missed before the last check-in.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Call to the
+ shell DOMWindow; not sure this one matters, but it's closer to the old
+ code before my last patch. Also pass the DOMWindow rather than the
+ frame to crossDomainAccessErrorMessage.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::setLocation): Pass DOMWindow rather than Frame
+ to the DOMWindow::setLocation function.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::setLocation): Take DOMWindow rather than Frame.
+ (WebCore::DOMWindow::crossDomainAccessErrorMessage): Ditto.
+
+ * page/DOMWindow.h: Update new functions to take DOMWindow rather
+ than Frame.
+
+2010-12-09 Sam Weinig <sam@webkit.org>
+
+ Try and fix the mac build.
+
+ * WebCore.exp.in:
+
+2010-12-09 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Dave Hyatt.
+
+ Removed an unused variable.
+
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::computeLogicalBoxHeights): Removed parentLineHeight.
+
+2010-12-09 Darin Adler <darin@apple.com>
+
+ Reviewed by Geoffrey Garen.
+
+ Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
+ https://bugs.webkit.org/show_bug.cgi?id=50640
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::printErrorMessageForFrame): Removed body; just call through to
+ DOMWindow::printErrorMessage.
+
+ * bindings/js/JSDOMWindowBase.cpp:
+ (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Removed body;
+ just call through to DOMWindow::crossDomainAccessErrorMessage.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::setLocation): Changed terminology to use activeFrame and
+ firstFrame, rather than the older lexicalFrame and dynamicFrame. Removed most
+ of the body and moved it into DOMWindow::setLocation.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::setLocation): Added. Does all the same work that
+ JSDOMWindow::setLocation used to do, but in a way that's not specific
+ to JavaScript.
+ (WebCore::DOMWindow::printErrorMessage): Added.
+ (WebCore::DOMWindow::crossDomainAccessErrorMessage): Added.
+
+ * page/DOMWindow.h: Added setLocation, printErrorMessage, and
+ crossDomainAccessErrorMessage.
+
+2010-12-09 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ WebKit2 needs smooth scrolling support on the mac
+ <rdar://problem/8219402>
+
+ * WebCore.xcodeproj/project.pbxproj: Change ScrollAnimatorMac.cpp to ScrollAnimatorMac.mm.
+ * platform/mac/ScrollAnimatorMac.cpp: Removed.
+ * platform/mac/ScrollAnimatorMac.h:
+ * platform/mac/ScrollAnimatorMac.mm: Copied from platform/mac/ScrollAnimatorMac.cpp.
+ (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]):
+ (-[ScrollAnimationHelperDelegate bounds]):
+ (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
+ (-[ScrollAnimationHelperDelegate convertSizeToBase:]):
+ (-[ScrollAnimationHelperDelegate convertSizeFromBase:]):
+ (-[ScrollAnimationHelperDelegate superview]):
+ (-[ScrollAnimationHelperDelegate documentView]):
+ (-[ScrollAnimationHelperDelegate window]):
+ (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]):
+ (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
+ (WebCore::ScrollAnimatorMac::scroll):
+ (WebCore::ScrollAnimatorMac::setScrollPositionAndStopAnimation):
+ (WebCore::ScrollAnimatorMac::currentPosition):
+ (WebCore::ScrollAnimatorMac::immediateScrollToPoint):
+ Add implementation of ScrollAnimator for the Mac.
+
+2010-12-09 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ <rdar://problem/8613779> and https://bugs.webkit.org/show_bug.cgi?id=50777
+ WebKit2 ContextMenuClient support
+
+ Export some symbols and headers needed by WebKit2 Mac:
+ * WebCore.exp.in:
+ * WebCore.xcodeproj/project.pbxproj:
+
+2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
+
+ Unreviewed, rolling out r73635.
+ http://trac.webkit.org/changeset/73635
+ https://bugs.webkit.org/show_bug.cgi?id=50778
+
+ 'Side-effects on 3 css tests needs closer review' (Requested
+ by mwenge on #webkit).
+
+ * platform/graphics/qt/ImageQt.cpp:
+ (loadResourcePixmap):
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
+ (WebCore::RenderThemeQt::paintSearchField):
+ (WebCore::RenderThemeQt::adjustSearchFieldStyle):
+ (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
+ (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
+ * platform/qt/RenderThemeQt.h:
+
+2010-12-09 Robert Hogan <robert@webkit.org>
+
+ Reviewed by Andreas Kling.
+
+ [Qt] Search input field doesn't have cancel button
+
+ Add a cancel button to the search field and make it customizable
+ by the client. For now, use the close dialog button associated
+ with the application's style as the default.
+
+ https://bugs.webkit.org/show_bug.cgi?id=42887
+
+ * platform/graphics/qt/ImageQt.cpp:
+ (loadResourcePixmap):
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
+ (WebCore::RenderThemeQt::paintSearchField):
+ (WebCore::RenderThemeQt::adjustSearchFieldStyle):
+ (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
+ (WebCore::RenderThemeQt::convertToPaintingRect):
+ (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
+ * platform/qt/RenderThemeQt.h:
+
+2010-12-09 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Antonio Gomes.
+
+ Spatial Navigation: Crash when handling iframe of size 0.
+ https://bugs.webkit.org/show_bug.cgi?id=50730
+
+ if we have a frame of size 0, we would get into infinite loop and eventually crash. The reason is
+ that when the algorithm sees a starting rect of size 0, it assumes that there is no focused node,
+ thus restarts itself. The solution is to avoid considering iframes with size 0 for the spatial
+ navigation algorithm.
+
+ Test: fast/spatial-navigation/snav-hidden-iframe-zero-size.html
+
+ * page/FocusController.cpp:
+ (WebCore::updateFocusCandidateIfNeeded):
+
+2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
+
+ Unreviewed, rolling out r73616.
+ http://trac.webkit.org/changeset/73616
+ https://bugs.webkit.org/show_bug.cgi?id=50772
+
+ Breaks chromium win build (Requested by hwennborg on #webkit).
+
+ * bindings/v8/IDBBindingUtilities.cpp:
+ (WebCore::createIDBKeyFromValue):
+ * bindings/v8/custom/V8IDBKeyCustom.cpp:
+ (WebCore::toV8):
+ * storage/IDBFactoryBackendImpl.cpp:
+ (WebCore::createTables):
+ (WebCore::IDBFactoryBackendImpl::open):
+ * storage/IDBKey.cpp:
+ (WebCore::IDBKey::IDBKey):
+ (WebCore::IDBKey::fromQuery):
+ (WebCore::IDBKey::bind):
+ (WebCore::IDBKey::bindWithNulls):
+ * storage/IDBKey.h:
+ (WebCore::IDBKey::create):
+ (WebCore::IDBKey::number):
+
+2010-12-09 Antonio Gomes <agomes@rim.com>
+
+ Rubber stamped by by Gustavo Noronha Silva.
+
+ Buildfix for GTK+ with building with -no-video.
+
+ paintStockIcon static function was implemented under the ENABLE(VIDEO) guard
+ but used from outside the guard. See RenderThemeGtk::paintSearchFieldResultsDecoration()
+ and RenderThemeGtk::paintSearchFieldCancelButton() methods.
+
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::getMediaElementFromRenderObject):
+
+2010-12-07 Antonio Gomes <agomes@rim.com>
+
+ Reviewed by Daniel Bates.
+
+ Spatial Navigation: code clean up
+ https://bugs.webkit.org/show_bug.cgi?id=50666
+
+ Patch unifies two FocusCandidate constructors, making caller sites
+ simpler. Now the special handling HTMLAreaElement gets is done within
+ the non default constructor (i.e. FocusCanditate(Node*, FocusDirection)).
+
+ No new tests needed.
+
+ * page/FocusController.cpp:
+ (WebCore::FocusController::findFocusCandidateInContainer):
+ * page/SpatialNavigation.cpp:
+ (WebCore::FocusCandidate::FocusCandidate):
+
+2010-12-09 Philippe Normand <pnormand@igalia.com>
+
+ Reviewed by Eric Carlson.
+
+ [GStreamer] disable fullscreen on MacOS Tiger and Leopard
+ https://bugs.webkit.org/show_bug.cgi?id=50748
+
+ Don't support fullscreen video on Tiger and Leopard, just like the
+ QTKit player.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::supportsFullscreen):
+
+2010-12-06 Philippe Normand <pnormand@igalia.com>
+
+ Reviewed by Martin Robinson.
+
+ [GTK] Support the Mozilla-style Fullscreen Javascript API
+ https://bugs.webkit.org/show_bug.cgi?id=50572
+
+ * GNUmakefile.am: enable the Javascript Fullscreen API feature if
+ it's been requested at configure time.
+
+2010-12-09 Yong Li <yoli@rim.com>
+
+ Reviewed by Darin Adler.
+
+ Check the return value of ImageBuffer::create()
+ to avoid crash when ImageBuffer::create() fails.
+ https://bugs.webkit.org/show_bug.cgi?id=50631
+
+ No new test because it relies on the platform implementation
+ of ImageBuffer. It is hard to make ImageBuffer::create() fail
+ in most ports.
+
+ * platform/graphics/GeneratedImage.cpp:
+ (WebCore::GeneratedImage::drawPattern):
+
+2010-12-09 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Implement "Use Selection for Find" in WebKit2
+ https://bugs.webkit.org/show_bug.cgi?id=50737
+ <rdar://problem/8564881>
+
+ Implement a TakeFindStringFromSelection editor command. This is
+ used solely to implement the "Use Selection for Find" menu command
+ on Mac, and is not made available to script. On WebKit2, it is
+ very convenient to reuse the editing machinery since this command
+ is very similar to Copy.
+
+ * editing/Editor.h:
+ * editing/EditorCommand.cpp:
+ (WebCore::executeTakeFindStringFromSelection): Call to a mac-only Editor function.
+ (WebCore::enabledTakeFindStringFromSelection): Check using Editor::canCopyExcludingStandaloneImage
+ (WebCore::createCommandMap): Add "TakeFindStringFromSelection" command.
+ * editing/mac/EditorMac.mm:
+ (WebCore::Editor::canCopyExcludingStandaloneImages): Helper function; we can't use Editor::canCopy
+ since it would make no sense to enable "Use Selection for Find" when viewing a standalone image
+ document.
+ (WebCore::Editor::takeFindStringFromSelection): Implement by copying the selected text
+ to the special Find pasteboard.
+
+2010-12-09 Abhishek Arya <inferno@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ As part of r73559, I added the referenceNode check to validate whether the root
+ node of the iterator matches the node which is getting moved to other document.
+ referenceNode is initialized to root, however can get moved using previousNode
+ and nextNode methods, so it is required to use root directly.
+ https://bugs.webkit.org/show_bug.cgi?id=50764
+
+ Test: fast/dom/node-iterator-reference-node-moved-crash.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::moveNodeIteratorsToNewDocument): change referenceNode to root.
+
+2010-12-08 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Provide a generic way to store shadowParent on a Node.
+ https://bugs.webkit.org/show_bug.cgi?id=50184
+
+ This patch makes TreeShared::m_parent act as either parentNode() or
+ shadowHost() for Node. The distinction is controlled by IsShadowRootFlag.
+
+ Refactoring, so no new tests. See performance result testing in bug.
+
+ * dom/Element.cpp:
+ (WebCore::Element::recalcStyle): Changed to use parentOrHostNode().
+ * dom/Node.cpp:
+ (WebCore::Node::shadowHost): Added.
+ (WebCore::Node::setShadowHost): Added.
+ (WebCore::Node::isContentEditable): Changed to use parentOrHostNode().
+ (WebCore::Node::isContentRichlyEditable): Ditto.
+ (WebCore::Node::nextRenderer): Ditto.
+ (WebCore::Node::virtualComputedStyle): Ditto.
+ (WebCore::Node::canStartSelection): Ditto.
+ (WebCore::Node::shadowTreeRootNode): Changed to use parentNodeGuaranteedHostFree().
+ (WebCore::Node::getEventAncestors): Ditto.
+ (WebCore::Node::defaultEventHandler): Changed to use parentOrHostNode().
+ * dom/Node.h: Added an extra flag and adjusted bit counts.
+ (WebCore::Node::isShadowNode): Made non-virtual, switched to use flag.
+ (WebCore::Node::parentNode): Made to recognize flag.
+ (WebCore::Node::parentOrHostNode): Changed to use straight parent() and made const.
+ (WebCore::Node::parentNodeGuaranteedHostFree): Added.
+ (WebCore::Node::shadowParentNode): Made non-virtual and const.
+ * editing/TextIterator.cpp:
+ (WebCore::depthCrossingShadowBoundaries): Changed to use parentOrHostNode();
+ (WebCore::nextInPreOrderCrossingShadowBoundaries): Ditto.
+ (WebCore::previousInPostOrderCrossingShadowBoundaries): Ditto.
+ (WebCore::setUpFullyClippedStack): Ditto.
+ (WebCore::TextIterator::advance): Ditto.
+ (WebCore::SimplifiedBackwardsTextIterator::advance): Ditto.
+ * page/DOMSelection.cpp:
+ (WebCore::DOMSelection::anchorNode): Changed to use parentNodeGuaranteedHostFree().
+ (WebCore::DOMSelection::focusNode): Ditto.
+ (WebCore::DOMSelection::baseNode): Ditto.
+ (WebCore::DOMSelection::extentNode): Ditto.
+ (WebCore::DOMSelection::getRangeAt): Ditto.
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
+ Changed to setShadowHost().
+ (WebCore::MediaControlShadowRootElement::updateStyle): Changed to use shadowHost().
+ (WebCore::MediaControlShadowRootElement::detach): Added an override to
+ explicitly set shadowHost to 0. Otherwise, the element will leak.
+ * rendering/MediaControlElements.h: Added detach def, removed members that are
+ no longer needed.
+ * rendering/RenderSVGShadowTreeRootContainer.cpp:
+ (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):
+ Added explicit clearing of shadowHost to avoid leaking and crashes,
+ because SVG shadow DOM can be dynamically attached/detached, producing
+ stale nodes in over/out event handling.
+ * rendering/RenderSlider.cpp:
+ (WebCore::SliderThumbElement::defaultEventHandler): Changed to use shadowHost().
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
+ Added explicit clearing of shadowHost and explicit destruction to
+ avoid out-of-order removal of children.
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::nodePosition): Simplified code.
+ * rendering/SVGShadowTreeElements.cpp:
+ (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): Added
+ setting of shadowHost.
+ (WebCore::SVGShadowTreeRootElement::attachElement): Changed to use shadowHost().
+ (WebCore::SVGShadowTreeRootElement::clearShadowHost): Added.
+ * rendering/SVGShadowTreeElements.h: Added def, removed members that are
+ no longer needed.
+ * rendering/ShadowElement.cpp:
+ (WebCore::ShadowBlockElement::initAsPart): Changed to use shadowHost().
+ * rendering/ShadowElement.h: Removed members that are no longer needed.
+ (WebCore::ShadowElement::ShadowElement): Added setting of shadowHost.
+ (WebCore::ShadowElement::detach): Added.
+ * rendering/TextControlInnerElements.cpp:
+ (WebCore::TextControlInnerElement::TextControlInnerElement): Added setting
+ of shadowHost.
+ (WebCore::TextControlInnerElement::attachInnerElement): Changed to use
+ isShadowNode().
+ (WebCore::TextControlInnerElement::detach): Added.
+ * rendering/TextControlInnerElements.h: Removed members that are no
+ longer needed.
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::ownerSVGElement): Simplified code.
+ (WebCore::SVGElement::viewportElement): Ditto.
+ * svg/SVGLocatable.cpp:
+ (WebCore::SVGLocatable::computeCTM): Ditto.
+ * svg/SVGStyledElement.cpp:
+ (WebCore::SVGStyledElement::title): Ditto.
+ * svg/SVGUseElement.cpp:
+ (WebCore::ShadowTreeUpdateBlocker::while): Ditto.
+
+2010-12-09 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
+ WebKit2 Authentication Support
+
+ * WebCore.exp.in:
+
+2010-12-09 Peter Beverloo <peter@lvp-media.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Default CSS definitions for the figure and figcaption elements.
+
+ Tests: fast/html/figcaption-element.html
+ fast/html/figure-element.html
+
+ * css/html.css:
+ (figure): The default figure-style equals a blockquote
+ (figcaption): A non-sectioning block-level element
+
+2010-12-09 Yury Semikhatsky <yurys@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: Console records for failed XHRs should contain call stack and request method
+ https://bugs.webkit.org/show_bug.cgi?id=50390
+
+ When inspector front-end is open we capture call stack at the place where request is sent and
+ pass the stack along with other request data. There is a new type of console messages which
+ is NetworkErrorMessageType, all messages of that type will have requestId field initialized
+ with the corresponding network request identifier so that later on when we need to display
+ that message in the front-end we could pull request data from the Network panel using
+ this identifier. If there are no data for given requestId message formatting falls back to
+ the old implementation which lacks such things as call stack, request method and exact
+ source location.
+
+ * inspector/ConsoleMessage.cpp:
+ (WebCore::ConsoleMessage::ConsoleMessage):
+ (WebCore::ConsoleMessage::addToFrontend):
+ (WebCore::ConsoleMessage::isEqual):
+ * inspector/ConsoleMessage.h:
+ * inspector/Inspector.idl:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didReceiveResponse):
+ (WebCore::InspectorController::didFailLoading):
+ * inspector/InspectorResourceAgent.cpp:
+ (WebCore::InspectorResourceAgent::identifierForInitialRequest):
+ * inspector/front-end/ConsoleView.js:
+ (WebInspector.ConsoleView.prototype.updateMessageRepeatCount):
+ (WebInspector.ConsoleMessage):
+ (WebInspector.ConsoleMessage.prototype._formatMessage):
+ (WebInspector.ConsoleMessage.prototype.toMessageElement):
+ (WebInspector.ConsoleMessage.prototype.toString):
+ (WebInspector.ConsoleMessage.prototype.isEqual):
+ * inspector/front-end/ResourceManager.js:
+ (WebInspector.ResourceManager.prototype.identifierForInitialRequest):
+ * inspector/front-end/inspector.js:
+ (WebInspector.addConsoleMessage):
+ * page/Console.h:
+
+2010-12-09 Dai Mikurube <dmikurube@google.com>
+
+ Reviewed by Kent Tamura.
+
+ Implement "required" attribute for select tags
+ https://bugs.webkit.org/show_bug.cgi?id=50380
+
+ Test: fast/forms/select-live-pseudo-selectors.html
+ platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html
+
+ * dom/SelectElement.cpp:
+ (WebCore::SelectElement::updateValidity): Added. It's a pure virtual function which is prepared so that HTMLSelectElement::updateValidity() calls HTMLSelectElement::setNeedsValidityCheck().
+ (WebCore::SelectElement::parseMultipleAttribute): Added calling updateValidity().
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValidityCheck() to enable validity check after changing. No tests for this change since this function is not exposed to JavaScript or any web interface.
+ (WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsValidityCheck().
+ (WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setNeedsValidityCheck().
+ (WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to check if selecting an invalid or placeholder label option when a valid required attribute is specified.
+ (WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsValidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180.
+ (WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck().
+ (WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityCheck().
+ (WebCore::HTMLSelectElement::restoreFormControlState): Added calling setNeedsValidityCheck().
+ (WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNeedsValidityCheck().
+ (WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityCheck().
+ (WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck().
+ (WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setNeedsValidityCheck(). Skipped adding tests for this change as too complicated..
+ (WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityCheck().
+ (WebCore::HTMLSelectElement::isRequiredFormControl): Check if required or not.
+ (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added.
+ (WebCore::HTMLSelectElement::updateValidity): Added. It calls setNeedsValidityCheck().
+ * html/HTMLSelectElement.h:
+ (WebCore::HTMLSelectElement::isOptionalFormControl): Check if not required.
+ * html/HTMLSelectElement.idl: Added a required attribute to select elements..
+ * html/ValidityState.cpp:
+ (WebCore::ValidityState::valueMissing): Added valueMissing check for select elements into the global checker, ValidityState::valueMissing().
+ * wml/WMLSelectElement.h:
+ (WebCore::WMLSelectElement::updateValidity): Added. It does nothing.
+
+2010-12-07 Jeremy Orlow <jorlow@chromium.org>
+
+ Reviewed by Steve Block.
+
+ IndexedDB returns the wrong exceptions
+ https://bugs.webkit.org/show_bug.cgi?id=50632
+
+ IndexedDB exceptions need to have an offset so they can
+ be distinguished from DOM exceptions. We also need to
+ add strings for the various exceptions. Lastly, make
+ IDBDatabaseException use the common exception base class.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::setDOMException):
+ * bindings/v8/V8Proxy.cpp:
+ (WebCore::V8Proxy::setDOMException):
+ * dom/ExceptionCode.cpp:
+ (WebCore::getExceptionCodeDescription):
+ * dom/ExceptionCode.h:
+ * storage/IDBDatabaseError.h:
+ (WebCore::IDBDatabaseError::code):
+ * storage/IDBDatabaseException.h:
+ (WebCore::IDBDatabaseException::create):
+ (WebCore::IDBDatabaseException::ErrorCodeToExceptionCode):
+ (WebCore::IDBDatabaseException::IDBDatabaseException):
+ * storage/IDBDatabaseException.idl:
+
+2010-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Build fix for GTK+3. Use functions added for GTK+ 2.24 to get the
+ GDK window size.
+
+ * plugins/gtk/gtk2xtbin.c:
+ (gtk_xtbin_realize):
+
+2010-12-09 Siddharth Mathur <siddharth.mathur@nokia.com>
+
+ Reviewed by Laszlo Gombos.
+
+ Use BUILDING_WEBKIT like other ports
+ https://bugs.webkit.org/show_bug.cgi?id=50713
+
+ * WebCore.pro: Change BUILD_WEBKIT to BUILDING_WEBKIT
+
+2010-12-08 Erik Arvidsson <arv@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Replace getAttribute().isNull() with fastHasAttribute()
+ https://bugs.webkit.org/show_bug.cgi?id=50719
+
+ Covered by existing tests.
+
+ * dom/SelectElement.cpp:
+ (WebCore::SelectElement::reset):
+ * html/HTMLAppletElement.cpp:
+ (WebCore::HTMLAppletElement::rendererIsNeeded):
+ * html/HTMLCollection.cpp:
+ (WebCore::HTMLCollection::itemAfter):
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::formNoValidate):
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::noValidate):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::defaultChecked):
+ (WebCore::HTMLInputElement::multiple):
+ (WebCore::HTMLInputElement::webkitdirectory):
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::defaultSelected):
+ * html/HTMLScriptElement.cpp:
+ (WebCore::HTMLScriptElement::asyncAttributeValue):
+ (WebCore::HTMLScriptElement::deferAttributeValue):
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::allowsMultipleFiles):
+ (WebCore::RenderFileUploadControl::allowsDirectoryUpload):
+
+2010-12-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
+
+ Reviewed by Martin Robinson.
+
+ Full page size flash plugins do not show in all situations
+ https://bugs.webkit.org/show_bug.cgi?id=47742
+
+ This patch moves the plugin widget size allocation after the
+ NPP_SetWindow is called with the effect that the resize of Flash
+ content no longer result in grey flash. This seems logical since the
+ widget tree cannot be fully constructed before the plugin receives
+ the new container window.
+
+ Test: manual-tests/plugins/gtk-windowed-grey-glitch.html
+
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::setNPWindowIfNeeded):
+
2010-12-08 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
« no previous file with comments | « LayoutTests/storage/indexeddb/objectstore-cursor.html ('k') | WebCore/bindings/v8/IDBBindingUtilities.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698