Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3940)

Unified Diff: chrome/browser/dom_ui/options/advanced_options_handler.cc

Issue 5799001: DOMUI: Temporarily strip trailing colons from section titles until the strings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/dom_ui/options/advanced_options_handler.cc
diff --git a/chrome/browser/dom_ui/options/advanced_options_handler.cc b/chrome/browser/dom_ui/options/advanced_options_handler.cc
index d94f1c56bc3adc6a9112b302d18379a7c6b182c6..05b31a81d5aecef3b8113d5d35844548af55a263 100644
--- a/chrome/browser/dom_ui/options/advanced_options_handler.cc
+++ b/chrome/browser/dom_ui/options/advanced_options_handler.cc
@@ -13,6 +13,7 @@
#include "base/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/browser/dom_ui/options/options_managed_banner_handler.h"
+#include "chrome/browser/dom_ui/options/options_util.h"
#include "chrome/browser/download/download_manager.h"
#include "chrome/browser/download/download_prefs.h"
#include "chrome/browser/google/google_util.h"
@@ -82,7 +83,8 @@ void AdvancedOptionsHandler::GetLocalizedValues(
localized_strings->SetString("autoOpenFileTypesResetToDefault",
l10n_util::GetStringUTF16(IDS_OPTIONS_AUTOOPENFILETYPES_RESETTODEFAULT));
localized_strings->SetString("gearSettingsGroupName",
- l10n_util::GetStringUTF16(IDS_OPTIONS_GEARSSETTINGS_GROUP_NAME));
+ options_util::StripColon(
+ l10n_util::GetStringUTF16(IDS_OPTIONS_GEARSSETTINGS_GROUP_NAME)));
localized_strings->SetString("gearSettingsConfigureGearsButton",
l10n_util::GetStringUTF16(
IDS_OPTIONS_GEARSSETTINGS_CONFIGUREGEARS_BUTTON));
@@ -124,15 +126,25 @@ void AdvancedOptionsHandler::GetLocalizedValues(
l10n_util::GetStringUTF16(
IDS_OPTIONS_FONTSETTINGS_CUSTOMIZE_FONTS_BUTTON));
localized_strings->SetString("advancedSectionTitlePrivacy",
- l10n_util::GetStringUTF16(IDS_OPTIONS_ADVANCED_SECTION_TITLE_PRIVACY));
+ options_util::StripColon(
+ l10n_util::GetStringUTF16(
+ IDS_OPTIONS_ADVANCED_SECTION_TITLE_PRIVACY)));
localized_strings->SetString("advancedSectionTitleContent",
- l10n_util::GetStringUTF16(IDS_OPTIONS_ADVANCED_SECTION_TITLE_CONTENT));
+ options_util::StripColon(
+ l10n_util::GetStringUTF16(
+ IDS_OPTIONS_ADVANCED_SECTION_TITLE_CONTENT)));
localized_strings->SetString("advancedSectionTitleSecurity",
- l10n_util::GetStringUTF16(IDS_OPTIONS_ADVANCED_SECTION_TITLE_SECURITY));
+ options_util::StripColon(
+ l10n_util::GetStringUTF16(
+ IDS_OPTIONS_ADVANCED_SECTION_TITLE_SECURITY)));
localized_strings->SetString("advancedSectionTitleNetwork",
- l10n_util::GetStringUTF16(IDS_OPTIONS_ADVANCED_SECTION_TITLE_NETWORK));
+ options_util::StripColon(
+ l10n_util::GetStringUTF16(
+ IDS_OPTIONS_ADVANCED_SECTION_TITLE_NETWORK)));
localized_strings->SetString("advancedSectionTitleTranslate",
- l10n_util::GetStringUTF16(IDS_OPTIONS_ADVANCED_SECTION_TITLE_TRANSLATE));
+ options_util::StripColon(
+ l10n_util::GetStringUTF16(
+ IDS_OPTIONS_ADVANCED_SECTION_TITLE_TRANSLATE)));
localized_strings->SetString("translateEnableTranslate",
l10n_util::GetStringUTF16(IDS_OPTIONS_TRANSLATE_ENABLE_TRANSLATE));
#if !defined(OS_CHROMEOS)

Powered by Google App Engine
This is Rietveld 408576698