Issue 5791003: Fix: include result_codes.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5791003: Fix: include result_codes.h (Closed)

Created:
10 years ago by wyck

Modified:
9 years, 6 months ago

Reviewers:
Greg Spencer (Chromium), bryeung, sky

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, Peter Mayo

Base URL:
http://git.chromium.org/git/chromium.git

Visibility:
Public.

Description

Fix: include result_codes.h Build broken by gspencer@chromium.org: use of ResultCodes without including chrome/common/result_codes.h. TBR=sky@chromium.org BUG=touchui buildbot failure TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69136

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_views.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wyck

touchui build broke when gspencer@ made use of ResultCodes in RenderWidgetHostViewViews without including the appropriate ...

10 years ago (2010-12-14 15:58:09 UTC) #1

Greg Spencer (Chromium)

10 years ago (2010-12-14 17:29:13 UTC) #3

On 2010/12/14 16:57:15, sky wrote:
> OK

Yes, LGTM, but I'm confused as to why this happened: this change passed all four
trybots (win, linux, mac, linux_chromeos) and buildbots on TOT yesterday after
checkin.  Surely one of them should have failed?

How do I build touchui to make sure I don't break it in the future?

Expand Messages | Collapse Messages