Issue 579026: Move candidate_window from third_party/chromeos_text_input to chrome/browser/chromeos/text_input.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 579026: Move candidate_window from third_party/chromeos_text_input to chrome/browser/chromeos/text_input. (Closed)

Created:
10 years, 10 months ago by satorux1

Modified:
9 years, 7 months ago

Reviewers:
Yusuke Sato

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, Charlie Lee, mazda

Visibility:
Public.

Description

Move candidate_window from third_party/chromeos_text_input to chrome/browser/chromeos/text_input. Turned out there is no benefit of having this in a separate git repository. No code change in candidate_window.cc, but modified the copyright notice from Chromium OS Authors to Chromium Authors. Slightly modified text_input.gyp to make it compile. We'll also change cros_deps/DEPS in a separate CL. BUG=none TEST=confirmed candidate_window compiles as before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38345

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+978 lines, -1 line)			Patch
M	build/all.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/browser/chromeos/text_input/candidate_window.cc	View	1 chunk	+948 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/text_input/text_input.gyp	View	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

LGTM. Please run gcl try to make sure the all.gyp change does not break the ...

10 years, 10 months ago (2010-02-08 07:07:45 UTC) #2

satorux1

10 years, 10 months ago (2010-02-08 07:57:25 UTC) #3

Good point. Now try results are all green. Submitting...

On 2010/02/08 07:07:45, Yusuke Sato wrote:
> LGTM. Please run gcl try to make sure the all.gyp change does not break the
> build.

Expand Messages | Collapse Messages