Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1788)

Issue 579014: Make LASTCHANGE work properly for make build. (Closed)

Created:
10 years, 10 months ago by Michael Moss
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make LASTCHANGE work properly for make build. BUG=22044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M base/base.gyp View 1 chunk +3 lines, -1 line 0 comments Download
M build/util/build_util.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/installer.gyp View 4 chunks +6 lines, -2 lines 0 comments Download
M chrome/installer/mini_installer.gyp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Moss
This assumes we agree with http://codereview.chromium.org/574021/show (i.e. no gyp code changes necessary).
10 years, 10 months ago (2010-02-06 03:47:47 UTC) #1
bradn
10 years, 10 months ago (2010-02-07 06:21:10 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698