Issue 5790002: [gtk] tabcontents fade-out for instant.

Issue 5790002: [gtk] tabcontents fade-out for instant. (Closed)

Created:
10 years ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, rohitrao (ping after 24h)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[gtk] tabcontents fade-out for instant. BUG=58937 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69032

Patch Set 3 : compile fixes #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -40 lines)			Patch
M	chrome/browser/gtk/browser_window_gtk.cc	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view.h	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_gtk.h	View		4 chunks	+17 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_gtk.cc	View		7 chunks	+53 lines, -12 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_mac.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_views.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_views.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_win.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_win.cc	View	1 2	5 chunks	+17 lines, -10 lines	0 comments	Download
M	chrome/browser/renderer_host/test/test_render_view_host.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View		2 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/5790002/diff/1/chrome/browser/gtk/browser_window_gtk.cc File chrome/browser/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/5790002/diff/1/chrome/browser/gtk/browser_window_gtk.cc#newcode1127 chrome/browser/gtk/browser_window_gtk.cc:1127: #if 0 Did you intend to leave this ...

10 years ago (2010-12-11 00:16:26 UTC) #2

Evan Stade

updated http://codereview.chromium.org/5790002/diff/1/chrome/browser/gtk/browser_window_gtk.cc File chrome/browser/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/5790002/diff/1/chrome/browser/gtk/browser_window_gtk.cc#newcode1127 chrome/browser/gtk/browser_window_gtk.cc:1127: #if 0 On 2010/12/11 00:16:26, sky wrote: > ...

10 years ago (2010-12-11 00:22:20 UTC) #3

LGTM

Expand Messages | Collapse Messages