Issue 5790001: Remove parent window (dangling in background) for chrome://settings when invoked at OOBE screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5790001: Remove parent window (dangling in background) for chrome://settings when invoked at OOBE screen. (Closed)

Created:
10 years ago by Denis Lagno

Modified:
9 years, 6 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+cc_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove parent window (dangling in background) for chrome://settings when invoked at OOBE screen. Set correct parent window for proxy settings: "under the hood", not "network settings". Remove close button when invoked at OOBE screen because there already exists another close button. BUG=chromium-os:10035 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69118

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -3 lines)			Patch
M	chrome/browser/chromeos/login/proxy_settings_dialog.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/options.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/options_page.css	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/options_page.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages