Issue 5788002: Add some missing includes and other minor changes intended to keep...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5788002: Add some missing includes and other minor changes intended to keep... (Closed)

Created:
10 years ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Add some missing includes and other minor changes intended to keep the distance between bleeding edge and the gc branch minimal. Committed: http://code.google.com/p/v8/source/detail?r=6016

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -6 lines)			Patch
M	src/allocation.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/checks.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/globals.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap-profiler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap-profiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/spaces.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/spaces.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/spaces-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Søren Thygesen Gjesse

10 years ago (2010-12-14 22:02:22 UTC) #2

LGTM

- I have never been sure which year/year interval to put in the header though.