Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Side by Side Diff: src/arm/macro-assembler-arm.cc

Issue 5788001: ARM: Fix heap number allocation in lithium-codegen-arm that assumed... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1042 matching lines...) Expand 10 before | Expand all | Expand 10 after
1053 if (FLAG_debug_code) { 1053 if (FLAG_debug_code) {
1054 // Trash the registers to simulate an allocation failure. 1054 // Trash the registers to simulate an allocation failure.
1055 mov(result, Operand(0x7091)); 1055 mov(result, Operand(0x7091));
1056 mov(scratch1, Operand(0x7191)); 1056 mov(scratch1, Operand(0x7191));
1057 mov(scratch2, Operand(0x7291)); 1057 mov(scratch2, Operand(0x7291));
1058 } 1058 }
1059 jmp(gc_required); 1059 jmp(gc_required);
1060 return; 1060 return;
1061 } 1061 }
1062 1062
1063 // Assert that the register arguments are different and that none of
1064 // them are ip. ip is used explicitly in the code generated below.
1063 ASSERT(!result.is(scratch1)); 1065 ASSERT(!result.is(scratch1));
1064 ASSERT(!result.is(scratch2)); 1066 ASSERT(!result.is(scratch2));
1065 ASSERT(!scratch1.is(scratch2)); 1067 ASSERT(!scratch1.is(scratch2));
1068 ASSERT(!result.is(ip));
1069 ASSERT(!scratch1.is(ip));
1070 ASSERT(!scratch2.is(ip));
1066 1071
1067 // Check relative positions of allocation top and limit addresses. 1072 // Check relative positions of allocation top and limit addresses.
1068 // The values must be adjacent in memory to allow the use of LDM. 1073 // The values must be adjacent in memory to allow the use of LDM.
1069 // Also, assert that the registers are numbered such that the values 1074 // Also, assert that the registers are numbered such that the values
1070 // are loaded in the correct order. 1075 // are loaded in the correct order.
1071 ExternalReference new_space_allocation_top = 1076 ExternalReference new_space_allocation_top =
1072 ExternalReference::new_space_allocation_top_address(); 1077 ExternalReference::new_space_allocation_top_address();
1073 ExternalReference new_space_allocation_limit = 1078 ExternalReference new_space_allocation_limit =
1074 ExternalReference::new_space_allocation_limit_address(); 1079 ExternalReference::new_space_allocation_limit_address();
1075 intptr_t top = 1080 intptr_t top =
(...skipping 1026 matching lines...) Expand 10 before | Expand all | Expand 10 after
2102 2107
2103 void CodePatcher::Emit(Address addr) { 2108 void CodePatcher::Emit(Address addr) {
2104 masm()->emit(reinterpret_cast<Instr>(addr)); 2109 masm()->emit(reinterpret_cast<Instr>(addr));
2105 } 2110 }
2106 #endif // ENABLE_DEBUGGER_SUPPORT 2111 #endif // ENABLE_DEBUGGER_SUPPORT
2107 2112
2108 2113
2109 } } // namespace v8::internal 2114 } } // namespace v8::internal
2110 2115
2111 #endif // V8_TARGET_ARCH_ARM 2116 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698