Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 5788001: ARM: Fix heap number allocation in lithium-codegen-arm that assumed... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1673 matching lines...) Expand 10 before | Expand all | Expand 10 after
1684 res = DefineSameAsFirst(new LSmiUntag(value, needs_check)); 1684 res = DefineSameAsFirst(new LSmiUntag(value, needs_check));
1685 } 1685 }
1686 if (needs_check) { 1686 if (needs_check) {
1687 res = AssignEnvironment(res); 1687 res = AssignEnvironment(res);
1688 } 1688 }
1689 return res; 1689 return res;
1690 } 1690 }
1691 } else if (from.IsDouble()) { 1691 } else if (from.IsDouble()) {
1692 if (to.IsTagged()) { 1692 if (to.IsTagged()) {
1693 LOperand* value = UseRegister(instr->value()); 1693 LOperand* value = UseRegister(instr->value());
1694 LOperand* temp = TempRegister(); 1694 LOperand* temp1 = TempRegister();
1695 LOperand* temp2 = TempRegister();
1695 1696
1696 // Make sure that temp and result_temp are different registers. 1697 // Make sure that the temp and result_temp registers are
1698 // different.
1697 LUnallocated* result_temp = TempRegister(); 1699 LUnallocated* result_temp = TempRegister();
1698 LInstruction* result = new LNumberTagD(value, temp); 1700 LInstruction* result = new LNumberTagD(value, temp1, temp2);
1699 Define(result, result_temp); 1701 Define(result, result_temp);
1700 return AssignPointerMap(result); 1702 return AssignPointerMap(result);
1701 } else { 1703 } else {
1702 ASSERT(to.IsInteger32()); 1704 ASSERT(to.IsInteger32());
1703 LOperand* value = UseRegister(instr->value()); 1705 LOperand* value = UseRegister(instr->value());
1704 LInstruction* res = new LDoubleToI(value); 1706 LInstruction* res = new LDoubleToI(value);
1705 return AssignEnvironment(DefineAsRegister(res)); 1707 return AssignEnvironment(DefineAsRegister(res));
1706 } 1708 }
1707 } else if (from.IsInteger32()) { 1709 } else if (from.IsInteger32()) {
1708 if (to.IsTagged()) { 1710 if (to.IsTagged()) {
(...skipping 366 matching lines...) Expand 10 before | Expand all | Expand 10 after
2075 void LPointerMap::PrintTo(StringStream* stream) const { 2077 void LPointerMap::PrintTo(StringStream* stream) const {
2076 stream->Add("{"); 2078 stream->Add("{");
2077 for (int i = 0; i < pointer_operands_.length(); ++i) { 2079 for (int i = 0; i < pointer_operands_.length(); ++i) {
2078 if (i != 0) stream->Add(";"); 2080 if (i != 0) stream->Add(";");
2079 pointer_operands_[i]->PrintTo(stream); 2081 pointer_operands_[i]->PrintTo(stream);
2080 } 2082 }
2081 stream->Add("} @%d", position()); 2083 stream->Add("} @%d", position());
2082 } 2084 }
2083 2085
2084 } } // namespace v8::internal 2086 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698