Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 5787008: Makes instant not suggest string that look like urls. (Closed)

Created:
10 years ago by sky
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Makes instant not suggest string that look like urls. BUG=66887 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69343

Patch Set 1 #

Patch Set 2 : Merge and convert active to displayable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
M chrome/browser/instant/instant_browsertest.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M chrome/browser/instant/instant_controller.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/instant/instant_controller.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/instant/instant_loader.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 2 chunks +10 lines, -0 lines 0 comments Download
A chrome/test/data/instant/suggest_google.html View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
10 years ago (2010-12-14 22:39:35 UTC) #1
Jay Civelli
10 years ago (2010-12-15 21:16:35 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698