Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 5787004: [Linux] Workaround issue 45478: IME dysfunctional after BACKSPACE (Closed)

Created:
10 years ago by James Su
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, evanm
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

[Linux] Workaround issue 45478: IME dysfunctional after BACKSPACE The reason of the issue is ibus intercepts all key events and does not forward them to chrome at all, while webkit relies on key events to reset one of its internal flag. This CL just fakes key down/up events if the input method intercepts all key events. BUG=45478 TEST=see bug report. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69067

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add SendFakeKeyEvent(). #

Total comments: 1

Patch Set 3 : Rename SendFakeKeyEvent to SendFakeCompositionKeyEvent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -15 lines) Patch
M chrome/browser/renderer_host/gtk_im_context_wrapper.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/gtk_im_context_wrapper.cc View 1 2 5 chunks +33 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Su
10 years ago (2010-12-13 22:43:09 UTC) #1
Evan Martin
http://codereview.chromium.org/5787004/diff/1/chrome/browser/renderer_host/gtk_im_context_wrapper.cc File chrome/browser/renderer_host/gtk_im_context_wrapper.cc (right): http://codereview.chromium.org/5787004/diff/1/chrome/browser/renderer_host/gtk_im_context_wrapper.cc#newcode511 chrome/browser/renderer_host/gtk_im_context_wrapper.cc:511: host_view_->ForwardKeyboardEvent(fake_event); Since this occurs twice, maybe this could be ...
10 years ago (2010-12-13 22:46:00 UTC) #2
James Su
CL updated.
10 years ago (2010-12-13 23:08:04 UTC) #3
Evan Martin
10 years ago (2010-12-13 23:09:26 UTC) #4
LGTM

http://codereview.chromium.org/5787004/diff/5001/chrome/browser/renderer_host...
File chrome/browser/renderer_host/gtk_im_context_wrapper.h (right):

http://codereview.chromium.org/5787004/diff/5001/chrome/browser/renderer_host...
chrome/browser/renderer_host/gtk_im_context_wrapper.h:105: void
SendFakeKeyEvent(WebKit::WebInputEvent::Type type);
I guess this always sends a composition key event?  Maybe include composition in
the name of the function (as written it looks like it could just as well send
"enter").

Powered by Google App Engine
This is Rietveld 408576698