Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 5786004: Fix HttpListenSocket. (Closed)

Created:
10 years ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
Reviewers:
pfeldman1, pfeldman
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Fix HttpListenSocket. Don't release the reference to the ListenSocket before we pass it. This prevents trying to access a deleted object. BUG=59930 TEST=existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/server/http_listen_socket.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
willchan no longer on Chromium
10 years ago (2010-12-14 01:40:17 UTC) #1
pfeldman1
10 years ago (2010-12-14 12:33:14 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698