Issue 5785004: Store HostContentSettingsMap separately so we can access it from the IO thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5785004: Store HostContentSettingsMap separately so we can access it from the IO thread. (Closed)

Created:
10 years ago by Bernhard Bauer

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Store HostContentSettingsMap separately from the profile in ResourceMessageFilter so we can access it from the IO thread. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69204

Patch Set 1 #

Patch Set 2 : sync #

Total comments: 1

Patch Set 3 : sync; indent #

Patch Set 4 : compile fix #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	chrome/browser/renderer_host/render_message_filter.h	View	1 2 3	2 chunks	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/renderer_host/render_message_filter.cc	View	1 2	3 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

10 years ago (2010-12-14 19:41:46 UTC) #2

lgtm, thanks for the quick fix

http://codereview.chromium.org/5785004/diff/3001/chrome/browser/renderer_host...
File chrome/browser/renderer_host/resource_message_filter.cc (right):

http://codereview.chromium.org/5785004/diff/3001/chrome/browser/renderer_host...
chrome/browser/renderer_host/resource_message_filter.cc:824:
CONTENT_SETTINGS_TYPE_PLUGINS,
nit: tabbing is off

Expand Messages | Collapse Messages