chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc - Issue 5785001: A NativeViewHostViews class for embedding views inside NativeHostView instances.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc

Issue 5785001: A NativeViewHostViews class for embedding views inside NativeHostView instances. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed the location of the cast as per discussion with ben Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc

diff --git a/chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc b/chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc

index ac91ccc972d7a65d099da563999ec393999f7846..5abdc073bb32204328473d51ff9c7042a9f5cf69 100644

--- a/chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc

+++ b/chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc

@@ -161,7 +161,8 @@ void TabContentsViewViews::Focus() {

}

RenderWidgetHostView* rwhv = tab_contents()->GetRenderWidgetHostView();

- gtk_widget_grab_focus(rwhv ? rwhv->GetNativeView() : GetNativeView());

+ if (rwhv)

+ rwhv->Focus();

}

void TabContentsViewViews::SetInitialFocus() {

« chrome/browser/ui/views/dom_view.cc ('K') | « chrome/browser/ui/views/dom_view.cc ('k') | views/controls/native/native_view_host.h » ('j') | no next file with comments »