Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6510)

Unified Diff: chrome/browser/extensions/stateful_external_extension_provider.cc

Issue 5784004: Add DCHECKs to StatefulExternalExtensionProvider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/stateful_external_extension_provider.cc
diff --git a/chrome/browser/extensions/stateful_external_extension_provider.cc b/chrome/browser/extensions/stateful_external_extension_provider.cc
index d922db83c8639729ac2fde4449b6650928b93f79..f861af720d6580e8cee315afa734fdb1f5f1a0a1 100644
--- a/chrome/browser/extensions/stateful_external_extension_provider.cc
+++ b/chrome/browser/extensions/stateful_external_extension_provider.cc
@@ -34,6 +34,7 @@ StatefulExternalExtensionProvider::~StatefulExternalExtensionProvider() {
void StatefulExternalExtensionProvider::VisitRegisteredExtension(
Visitor* visitor) const {
+ DCHECK(prefs_.get());
for (DictionaryValue::key_iterator i = prefs_->begin_keys();
i != prefs_->end_keys(); ++i) {
const std::string& extension_id = *i;
@@ -120,12 +121,14 @@ void StatefulExternalExtensionProvider::VisitRegisteredExtension(
bool StatefulExternalExtensionProvider::HasExtension(
const std::string& id) const {
+ DCHECK(prefs_.get());
return prefs_->HasKey(id);
}
bool StatefulExternalExtensionProvider::GetExtensionDetails(
const std::string& id, Extension::Location* location,
scoped_ptr<Version>* version) const {
+ DCHECK(prefs_.get());
DictionaryValue* extension = NULL;
if (!prefs_->GetDictionary(id, &extension))
return false;
@@ -154,3 +157,7 @@ bool StatefulExternalExtensionProvider::GetExtensionDetails(
return true;
}
+
+void StatefulExternalExtensionProvider::set_prefs(DictionaryValue* prefs) {
+ prefs_.reset(prefs);
+}

Powered by Google App Engine
This is Rietveld 408576698