chrome/browser/extensions/external_pref_extension_provider.cc - Issue 5784004: Add DCHECKs to StatefulExternalExtensionProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_pref_extension_provider.cc

Issue 5784004: Add DCHECKs to StatefulExternalExtensionProvider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: " Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/external_pref_extension_provider.cc

diff --git a/chrome/browser/extensions/external_pref_extension_provider.cc b/chrome/browser/extensions/external_pref_extension_provider.cc

index 7580388cf4070c1750dece77d2485b10e5f57012..5a55ff2f0c185a86b572aa0cdeba962c6b95c422 100644

--- a/chrome/browser/extensions/external_pref_extension_provider.cc

+++ b/chrome/browser/extensions/external_pref_extension_provider.cc

@@ -23,7 +23,7 @@ ExternalPrefExtensionProvider::ExternalPrefExtensionProvider()

JSONFileValueSerializer serializer(json_file);

SetPreferences(&serializer);

} else {

- prefs_.reset(new DictionaryValue());

+ set_prefs(new DictionaryValue());

}

@@ -50,5 +50,5 @@ void ExternalPrefExtensionProvider::SetPreferences(

dictionary.reset(static_cast<DictionaryValue*>(extensions));

}

- prefs_.reset(dictionary.release());

+ set_prefs(dictionary.release());

}