Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: chrome/browser/extensions/external_policy_extension_provider.h

Issue 5784004: Add DCHECKs to StatefulExternalExtensionProvider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more DCHECKS! Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/external_policy_extension_provider.h
diff --git a/chrome/browser/extensions/external_policy_extension_provider.h b/chrome/browser/extensions/external_policy_extension_provider.h
index bb4cc7d71f163e67157b141dca4f3d1b6c7935e6..fa50c4d8887c7dc74f7f85eb7f0243eebdb56c66 100644
--- a/chrome/browser/extensions/external_policy_extension_provider.h
+++ b/chrome/browser/extensions/external_policy_extension_provider.h
@@ -14,11 +14,12 @@ class PrefService;
// A specialization of the ExternalExtensionProvider that uses
// prefs::kExtensionInstallForceList to look up which external extensions are
-// registered.
+// registered. The value of this preference is set via the constructor and
+// via |SetPreferences| in case of run-time updates.
jochen (gone - plz use gerrit) 2010/12/15 08:57:49 please add a comment that the object must be creat
gfeher 2010/12/15 13:44:58 Done.
class ExternalPolicyExtensionProvider
: public StatefulExternalExtensionProvider {
public:
- explicit ExternalPolicyExtensionProvider();
+ explicit ExternalPolicyExtensionProvider(const ListValue* forcelist);
virtual ~ExternalPolicyExtensionProvider();
// Set the internal list of extensions based on |forcelist|.
@@ -28,6 +29,9 @@ class ExternalPolicyExtensionProvider
private:
friend class MockExternalPolicyExtensionProviderVisitor;
+ // Set the internal list of extensions based on |forcelist|.
+ // Does not take ownership of |forcelist|.
+ void ProcessPreferences(const ListValue* forcelist);
};
#endif // CHROME_BROWSER_EXTENSIONS_EXTERNAL_POLICY_EXTENSION_PROVIDER_H_

Powered by Google App Engine
This is Rietveld 408576698