Add DCHECKs to StatefulExternalExtensionProvider

chrome/browser/extensions/external_policy_extension_provider.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTERNAL_POLICY_EXTENSION_PROVIDER_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTERNAL_POLICY_EXTENSION_PROVIDER_H_
 #pragma once
 
 #include "chrome/browser/extensions/stateful_external_extension_provider.h"
 
 class ListValue;
 class MockExternalPolicyExtensionProviderVisitor;
 class PrefService;
 
 // A specialization of the ExternalExtensionProvider that uses
 // prefs::kExtensionInstallForceList to look up which external extensions are

[jochen (gone - plz use gerrit), 2010/12/14 13:40:43]

actually it uses whatever is passed in the constructor, right?

[gfeher, 2010/12/14 14:23:15]

Not exactly. Added comment.

It would be nice to have an observer for that preference here, but this object
unfortunately lives on the FILE thread.

 // registered.
 class ExternalPolicyExtensionProvider
     : public StatefulExternalExtensionProvider {
  public:
-  explicit ExternalPolicyExtensionProvider();
+  explicit ExternalPolicyExtensionProvider(const ListValue* forcelist);
   virtual ~ExternalPolicyExtensionProvider();
 
   // Set the internal list of extensions based on |forcelist|.
   // Does not take ownership of |forcelist|.
   void SetPreferences(const ListValue* forcelist);

[jochen (gone - plz use gerrit), 2010/12/14 13:49:47]

are you still using this or can this be private?

[gfeher, 2010/12/14 14:23:15]

No, this is used to refresh the internal list from the outside. The observer can
not be easily moved inside, because this object lives on the FILE thread, as all
the other Observers.

 
  private:
   friend class MockExternalPolicyExtensionProviderVisitor;
 
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTERNAL_POLICY_EXTENSION_PROVIDER_H_